-
Notifications
You must be signed in to change notification settings - Fork 40
[FEATURE] add kernels skills add to the cli
#278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
kernels skill add to the clikernels skills add to the cli
sayakpaul
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this! Very interesting.
My main feedback is on the doc:
- Let's make what the current skill can do clearer.
- Let's supplement the results we got after applying the kernels.
- Example on how the generated kernels can be used with
get_kernel()so that the integration message it clear. - A note on the output quality (and potentially showing the outputs).
|
|
||
| def add_skill(args: Namespace) -> None: | ||
| if not (args.claude or args.codex or args.opencode or args.dest): | ||
| print( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should be able to do it via exposing a vendor option in the args and then restricting its choices to claude, codex, etc. for example? Do you reckon any disadvantages? The vendor could be an nargs to allow lists as an input.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a makes sense, but this in consistent with other cli tools. like hf and skills
This PR adds a new cli command for installing an agent compatible skill. Things to note:
kernelswill need to vendor this skill. I have added it to docs but not ToC. I think this is the easiest way, but I'm open to suggestions.You can test this out with:
kernels skills --helpkernels skills add --claudeetc.