fix(bonus-unit2): update deprecated Langfuse API and add missing ddgs dependency#681
Open
meatballg1210 wants to merge 1 commit into
Open
fix(bonus-unit2): update deprecated Langfuse API and add missing ddgs dependency#681meatballg1210 wants to merge 1 commit into
meatballg1210 wants to merge 1 commit into
Conversation
… dependency Update deprecated start_as_current_span/update_trace to v4 API and add ddgs to install command for DuckDuckGoSearchTool.
Author
|
Hi maintainers 👋 There's still 1 workflow awaiting approval. It would be great if someone could approve it and review the changes when you have a moment. Happy to address any feedback. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The "Additional Attributes" section uses deprecated Langfuse Python SDK v3 APIs
that have been removed in v4:
start_as_current_span()→ replaced bystart_as_current_observation()span.update_trace()→ replaced bypropagate_attributes()DuckDuckGoSearchToolrequires theddgspackage which is not includedin the install command. It belongs to smolagents'
toolkitoptional group,not
telemetry, sosmolagents[telemetry]does not install it.Changes
start_as_current_span→start_as_current_observation,update_trace→propagate_attributesddgsto the pip install command in Step 0Verification
ddgs:DuckDuckGoSearchTool()fails withModuleNotFoundErrorddgsadded: works correctlyReferences