fix: lowercase dict key 'futuristic gotham' in SuperheroPartyThemeTool#675
Open
octo-patch wants to merge 1 commit into
Open
fix: lowercase dict key 'futuristic gotham' in SuperheroPartyThemeTool#675octo-patch wants to merge 1 commit into
octo-patch wants to merge 1 commit into
Conversation
fixes huggingface#589) The themes dict used 'futuristic Gotham' (capital G) as a key, but the lookup uses category.lower(), so 'futuristic Gotham' input would become 'futuristic gotham' and never match the key. Fix by lowercasing the key across all language variants (en, es, fr, ko, zh-CN).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #589
Problem
The
SuperheroPartyThemeTool.forward()method usescategory.lower()to look up a theme in the dict, but the dict key was"futuristic Gotham"(capital G). Since.lower()produces"futuristic gotham", the lookup never matched and always returned the not-found message.Solution
Lowercase the dict key from
"futuristic Gotham"to"futuristic gotham"to match the.lower()lookup. Applied consistently across all language variants: en, es, fr, ko, zh-CN (bothtools.mdxandcode_agents.mdxwhere applicable).Testing
After the fix, calling the tool with
"futuristic Gotham"(or any capitalization) correctly returns"Neo-Gotham Night: A cyberpunk-style party...".