Skip to content

ci(release): retry stapler validate for the same CloudKit disconnects - #87

Merged
hubo1989 merged 1 commit into
mainfrom
hubo/translate-improve
Oct 28, 2026
Merged

hubo1989 merged 1 commit into
mainfrom
hubo/translate-improve

Conversation

@hubo1989

Copy link
Copy Markdown
Owner

背景

run 40621659172 中:公证 Accepted,stapler staple 在第 2 次重试成功(上一个 PR 的重试机制已生效):

status: Accepted
The staple and validate action failed! Error 68.   ← 第 1 次
The staple and validate action worked!             ← 第 2 次 ✅
The validate action failed! Error 68.              ← stapler validate 撞同样的 -1005

stapler validate 同样要向 api.apple-cloudkit.com 查票据,受同一瞬时断连影响。

变更

  • 新增 validate_with_retry(5 次、间隔 10s),用于 app 的 stapler validate

验证

重跑发版,期望 staple + validate 均通过并产出带正确 EdDSA 签名的 appcast。

Latest run (40621659172) shows notarization Accepted and staple
succeeded on retry, then 'stapler validate' died with the identical
NSURLErrorDomain -1005 against api.apple-cloudkit.com — validate hits
the same ticket lookup and needs the same tolerance.
@coderabbitai

coderabbitai Bot commented Oct 28, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: de0a3fc6-7560-4db3-b711-95ae32384031
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ⚠️ Failed 2026-10-28T02:43:03.760296Z
We couldn’t complete this review. Comment @codex review to try again.
63c7f56 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@hubo1989
hubo1989 merged commit c374010 into main Oct 28, 2026
2 checks passed
@github-actions

github-actions Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

🔍 OpenCodeReview found 1 issue(s) in this PR.

  • ✅ Successfully posted inline: 1 comment(s)

Comment on lines +329 to +332
echo "validate attempt $attempt for $target failed, retrying in 10s..."
sleep 10
done
return 1

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maintainability · low
最后一次(第 5 次)尝试失败后仍会打印 "retrying..." 并无意义地 sleep 10 秒才退出,日志具有误导性且浪费时间。建议仅在非最后一次尝试时才 sleep,或改为 while 循环在成功间隙重试。同样的问题也存在于上方的 staple_with_retry(属既有代码,可一并修复)。

Suggestion:

Suggested change
echo "validate attempt $attempt for $target failed, retrying in 10s..."
sleep 10
done
return 1
if [ "$attempt" -lt 5 ]; then
echo "validate attempt $attempt for $target failed, retrying in 10s..."
sleep 10
fi
done
return 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant