Repository navigation
ci(release): retry stapler validate for the same CloudKit disconnects - #87
Conversation
Latest run (40621659172) shows notarization Accepted and staple succeeded on retry, then 'stapler validate' died with the identical NSURLErrorDomain -1005 against api.apple-cloudkit.com — validate hits the same ticket lookup and needs the same tolerance.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
🔍 OpenCodeReview found 1 issue(s) in this PR.
|
| echo "validate attempt $attempt for $target failed, retrying in 10s..." | ||
| sleep 10 | ||
| done | ||
| return 1 |
There was a problem hiding this comment.
最后一次(第 5 次)尝试失败后仍会打印 "retrying..." 并无意义地 sleep 10 秒才退出,日志具有误导性且浪费时间。建议仅在非最后一次尝试时才 sleep,或改为 while 循环在成功间隙重试。同样的问题也存在于上方的 staple_with_retry(属既有代码,可一并修复)。
Suggestion:
| echo "validate attempt $attempt for $target failed, retrying in 10s..." | |
| sleep 10 | |
| done | |
| return 1 | |
| if [ "$attempt" -lt 5 ]; then | |
| echo "validate attempt $attempt for $target failed, retrying in 10s..." | |
| sleep 10 | |
| fi | |
| done | |
| return 1 |
背景
run 40621659172 中:公证
Accepted,stapler staple在第 2 次重试成功(上一个 PR 的重试机制已生效):stapler validate同样要向api.apple-cloudkit.com查票据,受同一瞬时断连影响。变更
validate_with_retry(5 次、间隔 10s),用于 app 的stapler validate验证
重跑发版,期望 staple + validate 均通过并产出带正确 EdDSA 签名的 appcast。