Repository navigation
ci(release): retry stapler when Apple CloudKit drops the connection - #86
Conversation
review_concurrency 2 avoids the free-tier limit that marks every review item rate_limited; max_tokens_budget and effort match the production verified configuration.
Notarization is now Accepted (submission 6aaacec9...) — the timestamp fix is proven. The job then died in 'stapler staple' with NSURLErrorDomain Code=-1005 'The network connection was lost.' ...api.apple-cloudkit.com/.../records/lookup Stapling downloads the ticket from Apple's CloudKit and is exposed to transient disconnects; retry up to 5 times (10s apart) for both the app and the DMG instead of failing the whole release.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
|
🔍 OpenCodeReview found 2 issue(s) in this PR.
|
| review_concurrency: 2 | ||
| max_tokens_budget: '2000000' | ||
| effort: medium |
There was a problem hiding this comment.
这里新增的三个输入(review_concurrency / max_tokens_budget / effort)属于第三方 action(alibaba/open-code-review)的 with 参数。GitHub Actions 对 action 不认识的输入名不会报错,只会静默忽略——如果上游 action.yml 中并未定义这些输入(或拼写/命名不同,如 maxTokensBudget),本配置将完全不生效且无任何告警,与注释中"收敛到 2 串行化"的意图相悖。建议对照上游 v1.13.3 的 action.yml 确认输入名与取值格式(尤其是 max_tokens_budget 用字符串 '2000000' 是否被 number 类型接受),并在 PR 说明中附上验证依据。
Suggestion:
| review_concurrency: 2 | |
| max_tokens_budget: '2000000' | |
| effort: medium | |
| # 以上游 action.yml 实际定义的输入名为准 | |
| review_concurrency: 2 | |
| max_tokens_budget: '2000000' | |
| effort: medium |
| echo "staple attempt $attempt for $target failed, retrying in 10s..." | ||
| sleep 10 | ||
| done | ||
| return 1 |
There was a problem hiding this comment.
重试循环在最后一次失败后仍会 sleep 10s 才返回 1,白白增加 10 秒流水线耗时。建议将 sleep 移到判断之后(最后一轮不再等待),例如改用 attempt < 5 && sleep 10 或先判断再 sleep。
Suggestion:
| echo "staple attempt $attempt for $target failed, retrying in 10s..." | |
| sleep 10 | |
| done | |
| return 1 | |
| echo "staple attempt $attempt for $target failed" | |
| if [ "$attempt" -lt 5 ]; then | |
| echo "retrying in 10s..." | |
| sleep 10 | |
| fi | |
| done | |
| return 1 |
背景
v1.0.3 发版(run 40620552648)公证已通过——
--timestamp修复实证有效:但随后
stapler staple拉票据时撞上 Apple CloudKit 瞬时断连:变更
stapler staple加重试(5 次、间隔 10s),app 与 DMG 两处说明
本 PR 同时包含分支上已有的
fe6847a ci(ocr): add z.ai rate-limit budget and effort settings(他人工作,原样保留)。验证
重跑发版流水线,期望公证 Accepted + staple 成功 + appcast EdDSA 签名可被
sign_update --verify验证。