Skip to content

ci(release): extend notarization wait and fail closed on non-Accepted status - #85

Merged
hubo1989 merged 1 commit into
mainfrom
hubo/translate-improve
Oct 28, 2026
Merged

hubo1989 merged 1 commit into
mainfrom
hubo/translate-improve

Conversation

@hubo1989

Copy link
Copy Markdown
Owner

背景

v1.0.3 首次发版(run 40511279710)中,--timestamp 修复已生效——签名不再被 Apple 直接拒(Invalid),改为持续 In Progress 直到 --wait --timeout 30m 超时:

Timeout of 1800 second(s) was reached before processing completed.
id: 9cb6311e-6052-45e8-88f0-6c9869ffe37f

随后 stapler staple 因票据尚未生成而报 Record not found / exit 65,真正原因被吞掉。

变更

  1. notarytool --timeout 30m → 120m(app 与 DMG 两处提交)
  2. 非 status: Accepted 一律硬失败,输出 submission id 与当前状态;Invalid 时拉取 Apple issues 日志
  3. 不再在未完成时继续走到 stapler 报难懂的 65

验证

需重跑发版流水线实证公证 Accepted + staple 通过,并产出可用的 Sparkle 更新链路。

… status

Previous run reached Apple's service but --wait timed out at 30m before
processing completed (submission 9cb6311e...), then stapler failed with
'Record not found'. Signatures are no longer rejected — that path is fixed.

- Raise notarytool --timeout to 120m for both app and DMG submissions
- Treat any non-Accepted outcome as a hard failure, print the submission
  id and current status, instead of continuing to stapler
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ⚠️ Failed 2026-10-28T02:18:45.029944Z
We couldn’t complete this review. Comment @codex review to try again.
82f2ad6 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@coderabbitai

coderabbitai Bot commented Oct 28, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 32fd5b56-7ba3-4315-9502-ae01911132e2
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

✅ OpenCodeReview: Review complete: 0 finding(s) across 1 selected item(s).

@hubo1989
hubo1989 merged commit 0fae381 into main Oct 28, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant