Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
44 commits
Select commit Hold shift + click to select a range
9e9f9b0
docs: windows PRD + cross-platform color history spec + 4 subagent br…
hubo1989 Nov 1, 2026
7d9dc7b
feat(windows): capture shell layer — WGC/DXGI/GDI chain, overlay, win…
hubo1989 Nov 1, 2026
5a49122
feat(windows): begin portable core models
hubo1989 Nov 1, 2026
daed543
feat: add macOS color history window
hubo1989 Nov 1, 2026
b9d5d19
feat(windows): translation/OCR services layer (task C)
hubo1989 Nov 1, 2026
50a7c95
feat(windows): complete US-W01 solution skeleton + portable Core layer
hubo1989 Nov 1, 2026
8ea421b
docs(prd): adjudicate task C deviations — config-slice registry cache…
hubo1989 Nov 1, 2026
e52dc5b
feat(color-history): pick hotkey, shared pick pipeline, spec-aligned …
hubo1989 Nov 1, 2026
e8b96e3
ci: add windows build+test workflow
hubo1989 Nov 2, 2026
fec18b1
ci: add windows build+test workflow
hubo1989 Nov 2, 2026
61e9307
fix(ci): toolset follows default, stdcpp20 pre-import, gcc include root
hubo1989 Nov 2, 2026
455792b
fix(ci): LanguageStandard must be ClCompile metadata, not a property
hubo1989 Nov 2, 2026
c7092c4
ci: CMake build + gcc paren fix, drop -Werror missing-field-init in p…
hubo1989 Nov 2, 2026
952e195
fix(ci): ID2D1Factory1, D2D1_ANTIALIAS_MODE_ALIASED, UNICODE defines,…
hubo1989 Nov 2, 2026
569e630
fix(ci): tests include root, drop WinAppSDK ref from skeleton App (ZW…
hubo1989 Nov 2, 2026
8f8b639
fix(ci): include Windows.Foundation.Collections.h for IIterable begin…
hubo1989 Nov 2, 2026
fb494b0
fix(ci): Metadata header, unused var, Direct3D11CaptureFrame namespace
hubo1989 Nov 2, 2026
e4be6b9
fix(ci): explicit float cast for fixture confidence (C4244 as error)
hubo1989 Nov 2, 2026
59845b2
fix(ci): Language ctor, qualify winrt OcrResult projection type
hubo1989 Nov 2, 2026
75d161a
fix(ci): unreferenced parameters in WGC placeholder stubs (C4100)
hubo1989 Nov 2, 2026
ea0943f
fix(ci): let amalgamated cpp provide main; link bcrypt.lib explicitly
hubo1989 Nov 2, 2026
bcf6a2c
fix(ci): OcrLine has no BoundingRect - union word rects
hubo1989 Nov 2, 2026
f81059d
ci: run tests on x64 only; ARM64 leg is compile+link check
hubo1989 Nov 2, 2026
cb930d8
ci: run tests on x64 only; ARM64 leg is compile+link check
hubo1989 Nov 2, 2026
c64e483
ci: run tests on x64 only; ARM64 leg is compile+link check
hubo1989 Nov 2, 2026
31e70a4
fix(ci): resolve fixture via fixtures/ subdir (MSBuild preserves rela…
hubo1989 Nov 2, 2026
72f40a3
fix(ci): link Core sources into nativeshell_smoke (14 unresolved exte…
hubo1989 Nov 2, 2026
14c748a
ci: run Core tests from windows/ so fixture resolves cwd-relative
hubo1989 Nov 2, 2026
fc1a41b
ci: fix exe path (build dir is under windows/)
hubo1989 Nov 2, 2026
49c9edf
docs: windows CI verification report (A/B/C all green on GH Actions)
hubo1989 Nov 2, 2026
ca96f3c
merge: color history window (task D, macOS)
hubo1989 Nov 2, 2026
b41feff
merge: windows skeleton + portable core (task A)
hubo1989 Nov 2, 2026
89af448
merge: windows capture shell (task B)
hubo1989 Nov 2, 2026
b64f7e3
merge: windows translation services (task C)
hubo1989 Nov 2, 2026
7fd7440
fix(windows): separate merged test suites
hubo1989 Nov 2, 2026
7c4be68
fix(windows): avoid merging system import libraries
hubo1989 Nov 2, 2026
f93378b
feat(windows): wire full screenshot-translate app flow
hubo1989 Nov 2, 2026
b65bf19
fix(windows): MSVC build fixes + FR-02 window-click wiring
hubo1989 Nov 2, 2026
a409151
fix(windows): qualify tf::Rect in AppMain fallback anchors
hubo1989 Nov 2, 2026
6ca06dc
fix(windows): compile task-C Core sources in the solution
hubo1989 Nov 2, 2026
2a11497
fix(windows): Core include path + distinct obj dir for src/ files
hubo1989 Nov 2, 2026
c25cacc
fix(windows): add src/VisualLineGrouping.cpp to Core project
hubo1989 Nov 2, 2026
e1875cc
feat(windows): app icon, tray refinements, update service, MSIX packa…
hubo1989 Nov 3, 2026
02ad4ff
fix(windows): clipboard timeouts + shell-foreground guard prevent tas…
hubo1989 Nov 3, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
160 changes: 160 additions & 0 deletions .github/workflows/windows-ci.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,160 @@
name: windows-ci

on:
push:
branches: [main, "hubo/**"]
paths:
- "windows/**"
- ".github/workflows/windows-ci.yml"
pull_request:
paths:
- "windows/**"
- ".github/workflows/windows-ci.yml"
workflow_dispatch:

jobs:
core-tests:
# Task A: solution skeleton + portable core models/algorithms.
name: Core tests (MSVC ${{ matrix.platform }})
runs-on: windows-latest
strategy:
fail-fast: false
matrix:
platform: [x64, ARM64]
configuration: [Release]
steps:
- uses: actions/checkout@v4

- name: Add MSBuild to PATH
uses: microsoft/setup-msbuild@v2

- name: Build solution
working-directory: windows
run: msbuild TransFrame.sln /m /p:Configuration=${{ matrix.configuration }} /p:Platform=${{ matrix.platform }} /warnaserror /verbosity:minimal

- name: Run Catch2 tests
# x64 runner cannot execute ARM64 binaries (no emulation on
# windows-latest); ARM64 leg proves compile+link only.
# Run from windows/ so the fixture path Tests/fixtures/... resolves
# cwd-relative (same as the local dev invocation).
if: matrix.platform == 'x64'
working-directory: windows
shell: pwsh
run: |
& ".\build\${{ matrix.platform }}\${{ matrix.configuration }}\TransFrame.Core.Tests\TransFrame.Core.Tests.exe"
exit $LASTEXITCODE

- name: Upload test binaries on failure
if: failure()
uses: actions/upload-artifact@v4
with:
name: core-tests-${{ matrix.platform }}-${{ matrix.configuration }}
path: windows/build
if-no-files-found: ignore

native-shell-tests:
# Task B: capture shell. Portable policy core + (on Windows) Win32/D2D/WGC TUs.
name: NativeShell (MSVC ${{ matrix.platform }})
runs-on: windows-latest
strategy:
fail-fast: false
matrix:
platform: [x64, ARM64]
configuration: [Release]
steps:
- uses: actions/checkout@v4

- name: Configure CMake
run: cmake -S windows/NativeShell -B windows/NativeShell/build -A ${{ matrix.platform }} -DCMAKE_BUILD_TYPE=${{ matrix.configuration }}

- name: Build
run: cmake --build windows/NativeShell/build --config ${{ matrix.configuration }} --parallel

- name: Run Catch2 tests
# x64 runner cannot execute ARM64 binaries (no emulation on
# windows-latest); ARM64 leg proves compile+link only.
if: matrix.platform == 'x64'
working-directory: windows/NativeShell/build/${{ matrix.configuration }}
run: .\native_shell_tests.exe

- name: Upload test binaries on failure
if: failure()
uses: actions/upload-artifact@v4
with:
name: nativeshell-tests-${{ matrix.platform }}-${{ matrix.configuration }}
path: windows/NativeShell/build
if-no-files-found: ignore

translation-tests:
# Task C: translation/OCR services. Core (portable) Catch2 tests on
# MSVC x64 + ARM64; NativeShell Win32/WinRT TUs compile+link into the
# smoke target (running it needs a GUI session - see windows/README.md).
name: Translation services (MSVC ${{ matrix.platform }})
runs-on: windows-latest
strategy:
fail-fast: false
matrix:
platform: [x64, ARM64]
configuration: [Release]
steps:
- uses: actions/checkout@v4

- name: Configure CMake
run: cmake -S windows -B windows/build -A ${{ matrix.platform }} -DCMAKE_BUILD_TYPE=${{ matrix.configuration }}

- name: Build
run: cmake --build windows/build --config ${{ matrix.configuration }} --parallel

- name: Run Catch2 tests (Core)
# x64 runner cannot execute ARM64 binaries (no emulation on
# windows-latest); ARM64 leg proves compile+link only.
if: matrix.platform == 'x64'
working-directory: windows/build/${{ matrix.configuration }}
run: .\translation_tests.exe

- name: Upload test binaries on failure
if: failure()
uses: actions/upload-artifact@v4
with:
name: translation-tests-${{ matrix.platform }}-${{ matrix.configuration }}
path: windows/build
if-no-files-found: ignore

portable-check:
# Prove the portable layers stay platform-clean: the same sources
# compile under GCC on Linux (no Win32 leaks).
name: Portable checks (GCC, ubuntu)
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4

- name: Validate MSIX update descriptors
run: python3 -m unittest discover -s windows/scripts -v

- name: Install compiler
run: sudo apt-get update && sudo apt-get install -y g++-13 cmake

- name: Core (task A) — build and run Catch2 tests
working-directory: windows
run: |
g++-13 -std=c++20 -Wall -Wextra -Werror \
-I . -I Core -I external \
Core/*.cpp external/catch2/catch_amalgamated.cpp \
Tests/TestMain.cpp Tests/CoreModelsTests.cpp Tests/LLMTranslationCoreTestsA.cpp \
Tests/TranslationPromptConfigTests.cpp Tests/VisualLineGroupingTests.cpp \
-o ../build-tests 2>&1 | head -80
../build-tests

- name: NativeShell (task B) — configure, build, test
run: |
cmake -S windows/NativeShell -B windows/NativeShell/build -DCMAKE_BUILD_TYPE=Release \
-DCMAKE_CXX_COMPILER=g++-13
cmake --build windows/NativeShell/build --parallel
windows/NativeShell/build/native_shell_tests

- name: Translation (task C) — configure, build, test
run: |
cmake -S windows -B windows/build-c -DCMAKE_BUILD_TYPE=Release \
-DCMAKE_CXX_COMPILER=g++-13
cmake --build windows/build-c --parallel
windows/build-c/translation_tests
4 changes: 4 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -100,3 +100,7 @@ build_artifacts/
.omd/
*.dmg
scripts/e2e/eventsynth

# Windows installer output and Python packaging tools
windows/dist/
__pycache__/
20 changes: 11 additions & 9 deletions TransFrame/App/AppDelegate.swift
Original file line number Diff line number Diff line change
Expand Up @@ -212,21 +212,23 @@ final class AppDelegate: NSObject, NSApplicationDelegate {

// MARK: - Color Picker & Image Editing Actions

/// Triggers the native macOS color picker to copy a hex color code
/// Triggers the native macOS color picker to copy a hex color code.
/// Routes through the shared pick pipeline (spec §4.5): clipboard +
/// history insert + toast, same as every other eyedropper surface.
@objc func pickScreenColor() {
NSColorSampler().show { selectedColor in
guard let color = selectedColor else { return }
guard let rgbColor = color.usingColorSpace(.sRGB) else { return }
let r = Int(round(rgbColor.redComponent * 255))
let g = Int(round(rgbColor.greenComponent * 255))
let b = Int(round(rgbColor.blueComponent * 255))
let hex = String(format: "#%02X%02X%02X", r, g, b)
NSPasteboard.general.clearContents()
NSPasteboard.general.setString(hex, forType: .string)
NotificationCenter.default.post(name: .colorDidPick, object: hex)
ColorPickFlow.complete(color)
}
}

/// Opens the independent color history window (spec §4.1)
@objc func openColorHistory() {
Logger.ui.debug("Opening color history window")

ColorHistoryWindowController.shared.showColorHistory()
}

/// Opens an image file from disk and launches the annotation editor
@objc func openImageForEditing() {
let panel = NSOpenPanel()
Expand Down
13 changes: 13 additions & 0 deletions TransFrame/App/Coordinators/HotkeyCoordinator.swift
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ final class HotkeyCoordinator {
case translationMode
case textSelectionTranslation
case translateAndInsert
case pickColor
}

// MARK: - Properties
Expand Down Expand Up @@ -122,6 +123,18 @@ final class HotkeyCoordinator {
}
}

// Register screen color pick hotkey (spec §4.2 empty-state hint,
// spec §4.5 pick → history flow)
await registerHotkey(
type: .pickColor,
shortcut: settings.pickColorShortcut,
description: "Screen Color Pick"
) { [weak self] in
Task { @MainActor in
self?.appDelegate?.pickScreenColor()
}
}

logger.info("All hotkeys registered successfully")
}

Expand Down
5 changes: 4 additions & 1 deletion TransFrame/Features/Capture/SelectionInPlaceToolbar.swift
Original file line number Diff line number Diff line change
Expand Up @@ -418,12 +418,15 @@ private struct ToolbarContentView: View {
.customTooltip(item.name, placement: .bottom)
}

// Screen eyedropper
// Screen eyedropper: feeds the annotation color and the
// shared color-history pipeline (spec §4.5); clipboard
// untouched mid-annotation.
Button {
NSColorSampler().show { picked in
guard let picked else { return }
state.activeColor = Color(nsColor: picked)
onColorSelected(picked)
ColorPickFlow.complete(picked, writeToPasteboard: false)
}
} label: {
Image(systemName: "eyedropper")
Expand Down
Loading
Loading