fix: keep bool parameters as bool in sklearn_tuner (#108)#122
Open
Nas01010101 wants to merge 1 commit into
Open
fix: keep bool parameters as bool in sklearn_tuner (#108)#122Nas01010101 wants to merge 1 commit into
Nas01010101 wants to merge 1 commit into
Conversation
|
|
`sklearn_tuner` casts every numeric discrete hyper-parameter to `int` before passing it to the estimator. `BoolPara` reports both `is_numeric` and `is_discrete` as True, so a `bool` parameter (e.g. `bootstrap`/`warm_start` of RandomForest) reaches the estimator as `0`/`1` instead of `False`/`True`. Recent scikit-learn validates the parameter type and raises, e.g. "The 'bootstrap' parameter ... must be an instance of 'bool' ... Got 0 instead." Keep bool parameters as python `bool`; only int-cast the remaining non-bool discrete numeric parameters. Adds a regression test that records the parameter types received by the estimator.
Nas01010101
force-pushed
the
fix/sklearn-tuner-bool-108
branch
from
660a47a to
582599c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sklearn_tunerint-casts every discrete numeric hyper-parameter:BoolParareports bothis_numericandis_discreteasTrue, so a boolean hyper-parameter (e.g. aRandomForest'sbootstrap) is cast to0/1. Modern scikit-learn then rejects it:This is issue #108.
Fix
Special-case
BoolParaso boolean parameters stay pythonbool, and only int-cast the remaining (non-bool) discrete numerics.Tests
Adds
test/test_sklearn_tuner_bool.py— a recorder estimator that asserts the parameter type it receives atfit. Fails before the fix (boolcoerced toint), passes after.Closes #108.