Fix build failures due to missing dependencies in package.xml#121
Open
FreeFeFive wants to merge 1 commit into
Open
Fix build failures due to missing dependencies in package.xml#121FreeFeFive wants to merge 1 commit into
FreeFeFive wants to merge 1 commit into
Conversation
There are some depended packages you write in the CMakeLists.txt but forgot to add in the package.xml, which would cause failure when building the ROS package.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have updated the
package.xmlfiles in two ROSLLM packages. The dependencies listed inCMakeLists.txtwere not synchronized withpackage.xml, which leads to build failures.Specifically:
rosllm_srvspackage depends onrosllm_msgs, but this was missing frompackage.xml. This caused build errors due to undefined compilation order.rosllm_msgspackage depends onsensor_msgs, which was also missing from itspackage.xml.I have fixed both issues, and the project now builds successfully on my machine.