Skip to content

feat(control-plane): promote the personal Agent workspace - #3274

Open
maxliux5 wants to merge 16 commits into
mainfrom
codex/promote-personal-workspace-rfc
Open

feat(control-plane): promote the personal Agent workspace#3274
maxliux5 wants to merge 16 commits into
mainfrom
codex/promote-personal-workspace-rfc

Conversation

@maxliux5

@maxliux5 maxliux5 commented Aug 16, 2026

Copy link
Copy Markdown
Collaborator

Summary

Promotes the personal Agent workspace RFC onto the latest main as one reviewable control-plane change set.

  • keeps the sidebar focused on LoopX Manager + Goals;
  • adds stable Manager Overview / Chat navigation and scoped Goal Chat / Tasks / Files views;
  • makes read-only chat, typed previews, receipts, Session progress/results, Files, image attachments, and Lark Goal Topic connections coherent;
  • retains the default theme plus the opt-in Beast theme;
  • serves the complete workspace through the supported local dashboard command.

Latest first screen

Default theme preview

The Beast theme, 110% zoom, narrow layout, mobile navigation, and keyboard focus paths were also exercised during real-browser acceptance.

Capability lineage and attribution

Capability Source PR Contributor Promotion validation
Personal workspace, Manager/Goal UX, Lark App + Topic connections, Session records #3167 Max Liu (@maxliux5) Contract, browser smoke, image/Lark/Session paths, cold-start CUA
Provider-neutral Goal token/cost/duration capture #3117 Niu Ruibo (@NIU-123370) Focused usage-summary tests and status projection coverage
Chinese responsive dashboard foundation #2793 @ACanvasHERE Dashboard build, responsive browser smoke, theme/zoom CUA
RFC integration, public/private cleanup, final state-truth repairs #3269 and this PR Original RFC contributors and promotion integrator Latest-main integration, DCO-clean history, public-boundary scan, focused regressions

Original PR links remain the canonical review history. Authors are preserved where commits could be promoted directly. The latest main sync is isolated in integration commit 0b0a2d67.

Safety model

Free text routes through the constrained contract:

route: projection | typed_action | agent_chat | clarify
action_kind
normalized_parameters
confidence
missing_fields

Explicit controls have priority. typed_action still requires canonical preview, state fingerprint, user confirmation, and receipt. Negation, compound intent, low confidence, and missing fields fail into clarification.

Validation

  • Node 22 dashboard TypeScript + production builds: passed
  • personal-workspace router smoke: passed
  • personal-workspace contract smoke: passed
  • dashboard home route smoke: passed
  • dashboard home browser smoke: passed
  • personal-workspace browser smoke: passed
  • focused Python promotion/main suite: 115 passed
  • status-server localhost fast-path test: passed
  • real Chrome Codex computer-use acceptance: five cold-start rounds plus final targeted regression
    • Manager Overview → transient answer → complete Chat → Overview
    • Goal Chat / Tasks / Files and Task drafting boundary
    • authoritative Session status/progress/output/run record (completed / 1/1)
    • default/Beast themes, 110% zoom, narrow/mobile navigation, keyboard focus
    • no preview confirmation or control-plane state write during read-only QA
  • private/local-path/credential scan: clean; only synthetic redaction fixtures matched

Integration notes

  • This clean Promotion PR supersedes #3269, whose historical branch cannot satisfy DCO without rewriting contributor history.
  • The promotion branch is based on current origin/main and is not behind it at publication time.
  • Generated UI assets are committed separately from runtime, tests, and docs.

maxliux5 added 14 commits August 17, 2026 02:21
@maxliux5
feat(chat): add durable Agent conversation runtime
00e8987 
Signed-off-by: maxliu <lualiudd@gmail.com>
@maxliux5
feat(lark): connect reusable Goal topic sessions
8305389 
Signed-off-by: maxliu <lualiudd@gmail.com>
@maxliux5
feat(status): project sessions, usage, and Goal connections
62ce1c2 
Signed-off-by: maxliu <lualiudd@gmail.com>
@maxliux5
feat(cli): serve the local personal workspace
bd9efb8 
Signed-off-by: maxliu <lualiudd@gmail.com>
@maxliux5
feat(ui): deliver the personal Agent workspace
9a9a4ab 
Signed-off-by: maxliu <lualiudd@gmail.com>
@maxliux5
test(control-plane): cover workspace promotion contracts
6dfd228 
Signed-off-by: maxliu <lualiudd@gmail.com>
@maxliux5
docs(workspace): document the promoted control plane
a604e42 
Signed-off-by: maxliu <lualiudd@gmail.com>
@maxliux5
docs(agents): preserve integration and repair boundaries
ed5bc76 
Signed-off-by: maxliu <lualiudd@gmail.com>
@maxliux5
fix(ui): restore authoritative workspace feedback
ea706db 
Signed-off-by: maxliu <lualiudd@gmail.com>
@maxliux5
test(dashboard): align home smoke with workspace IA
dc1ebdb 
Signed-off-by: maxliu <lualiudd@gmail.com>
@maxliux5
build(ui): refresh packaged workspace bundle
43df674 
Signed-off-by: maxliu <lualiudd@gmail.com>
@maxliux5
merge: sync latest main into workspace promotion
0b0a2d6 
Signed-off-by: maxliu <lualiudd@gmail.com>
@maxliux5
test(dashboard): preserve final workspace navigation
a09cbca 
Signed-off-by: maxliu <lualiudd@gmail.com>
@maxliux5
build(ui): refresh merged workspace bundle
3f395f9 
Signed-off-by: maxliu <lualiudd@gmail.com>
huangruiteng
huangruiteng reviewed Aug 16, 2026
View reviewed changes

@huangruiteng huangruiteng left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Request changes conclusion (author-owned PR; GitHub review-state fallback)

精确评审头（Exact Head）: 3274@3f395f9f4208b0ff5037ef4fbec20fb4c3967535
Base: main | 类型: personal Agent workspace 干净提升（133 files, +33631/-288）
作者: huangruiteng（owner；maxliux5/NIU-123370/ACanvasHERE 等贡献合入）

详细中文评审

动机

#3269 因 DCO（历史 commit 缺 trailer）与 CLI 输出差分超预算被 REQUEST_CHANGES；本 PR 在最新 main 上重建干净提升分支，解决 DCO（Sign-off SUCCESS），并把集成隔离在 0b0a2d67。核心内容与 #3269 相同：Manager/Goal workspace、受限 router、Preview/Apply 安全边界、Session 真相投影。

改动思路

以当前 origin/main 为基重建（不落后于 main），作者历史尽量直接保留，未满足 DCO 的 commit 通过重建分支解决；生成 UI 资产与 runtime/tests/docs 分提交。路由安全模型与 #3269 一致（projection / typed_action / agent_chat / clarify；typed_action 需 canonical preview + fingerprint + 确认 + receipt）。

具体改动

与 #3269 同规模的 133 文件提升（apps/presentation 前端 + control-plane 投影/状态面），集成 commit 0b0a2d67 隔离 latest-main 同步；新增 status-server localhost fast-path 测试等。

关键内容讲解

  1. DCO 已解决：Sign-off check SUCCESS（P1-1 清除）。
  2. CLI 输出差分未解决：pytest 仍 FAILURE——cli-output-base-head-differential-smoke.py 报 surface/status/crowded/json 与 multi_agent/json lines +5 (allowance 4)；surface/status/small/json chars +130 (allowance 128)、compact_payload_chars +95 (allowance 93)。与 #3269/#3269b 相同根因，仍在 allowance 之外。
  3. 其余检查：build ×2、dependency-review SUCCESS；deploy SKIPPED。

对主干的风险

阻断项（P1）

  1. pytest FAIL（CLI base/head differential）：agent-facing status JSON 输出仍超预算（lines +5 / chars +130）；需收敛 status 输出或在逐项证据基础上更新差分 allowance（不能只改阈值）。

非阻断（P2）

  • DCO 已清，可推进：CI 绿后仍需按提升门禁完成 router 安全/投影面的分片独立复核（本评审已覆盖 CI 证据与 diff 范围，完整逐行复核建议分片进行）。

验证矩阵（exact head 实测/CI）

场景 结果
Sign-off（DCO） SUCCESS（已修复）
pytest（CLI base/head differential） FAILURE（lines +5 vs 4；small/json chars +130 vs 128）
build ×2 / dependency-review SUCCESS
作者本地验证 115 focused Python tests + dashboard/router/browser smokes + CUA（claimed）
diff 范围 133 files, +33631/-288

我的整体评价

干净重建解决了 DCO，方向与 #3269 一致且集成隔离清楚；但 agent-facing CLI 输出差分这一 P1 仍未解决（数值与 #3269 一致）。结论：REQUEST_CHANGES（窄化：收敛 status JSON 输出至 allowance 内或提供逐项证据更新差分 allowance；随后完成分片安全面复核）。

English Verdict

Verdict: REQUEST_CHANGES — exact head 3274@3f395f9f4208b0ff5037ef4fbec20fb4c3967535.

Summary: This clean promotion resolves the DCO blocker (Sign-off SUCCESS) and isolates the latest-main sync in one integration commit, but the second P1 from #3269 remains: CI pytest fails on the agent-facing CLI base/head differential (status rows lines +5 vs allowance 4; small/json chars +130 vs allowance 128). Builds and dependency-review pass. Once the CLI output budget is reconciled, the staged independent review of the router safety and projection surfaces can proceed.

@maxliux5
fix(status): keep boundary diagnostics off hot path
d030e66 
Signed-off-by: maxliu <lualiudd@gmail.com>
huangruiteng
huangruiteng reviewed Aug 16, 2026
View reviewed changes

@huangruiteng huangruiteng left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approval conclusion (author-owned PR; GitHub blocks formal self-approval)

精确评审头（Exact Head）: 3274@d030e6639077ae04994c81f3063a28d388000c1c
Base: main | 类型: Agent workspace 提升的 CLI 输出预算修复（2 files, +18/-2）
作者: huangruiteng（owner；多贡献者合入）

详细中文评审

动机

上一轮 REQUEST_CHANGES 的 P1（agent-facing CLI base/head 差分超预算）由新 commit d030e6639（fix(status): keep boundary diagnostics off hot path）修复：把 public_boundary_scan 从 status contract 的 hot-path 投影中移除，改为 checks 里的 deferred 提示（public boundary scan deferred for status hot path），并保留 check 命令作为发布前入口。

改动思路

最小收敛：status hot path 不再透传 public_boundary_scan 明细（减少 JSON 输出），只保留一行 deferred 提示；测试锁定新行为（无 capability 时 contract 不含 public_boundary_scan，checks 含 deferred 提示），新增专用回归测试。

具体改动

  • loopx/control_plane/status/collection.py（-1）：从 hot-path 投影字段中移除 public_boundary_scan。
  • tests/control_plane/test_status_collection_material_capability_wiring.py（+19/-2）：fixture 更新 + 新增 test_status_collection_keeps_boundary_detail_off_the_hot_path。

关键内容讲解

  1. 预算修复验证：本地 exact head 复跑 cli-output-base-head-differential-smoke.py PASS（此前 lines +5 / chars +130 超限已消失）。
  2. 行为保持：boundary 扫描未删除，只是移出 status hot path；loopx check 仍是发布前扫描入口（recommended_action 保留）。
  3. 回归锁定：新测试断言 deferred 提示存在、明细字段不在 contract。

对主干的风险

无阻断项。Sign-off、dependency-review SUCCESS；build ×2（一个 CANCELLED 为旧 run）、pytest IN_PROGRESS（无失败）。P2 保持：CI 绿后按提升门禁完成 router 安全/投影面的分片独立复核（本评审覆盖 CI 证据与关键修复点，完整逐行复核建议分片进行）。

验证矩阵（exact head 实测/CI）

场景 结果
cli-output-base-head-differential-smoke.py（本地复跑） PASS（P1 修复确认）
test_status_collection_material_capability_wiring.py 6 passed
Sign-off / dependency-review SUCCESS
build ×2 / deploy SUCCESS / CANCELLED（旧 run）
pytest（CI） IN_PROGRESS（评审时刻）

我的整体评价

一个字段的 hot-path 收敛即解决超预算，且不丢失扫描能力；本地差分 smoke 与回归测试全绿。结论：APPROVE（author-owned PR，以 COMMENTED 记录批准结论；合并前确认 CI pytest 绿）。

English Verdict

Verdict: APPROVE (author-owned PR; recorded as COMMENTED because GitHub blocks formal self-approval). The new commit keeps public_boundary_scan detail off the status hot path (deferred note only), which fixes the agent-facing CLI base/head differential: the previously failing differential smoke now passes at the exact head, along with the focused status-collection regression tests. Sign-off and dependency-review are green; CI pytest was in progress at review time.

@maxliux5
merge: sync latest main before promotion
0eb251f 
Signed-off-by: maxliu <lualiudd@gmail.com>
huangruiteng
huangruiteng reviewed Aug 16, 2026
View reviewed changes

@huangruiteng huangruiteng left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approval conclusion (author-owned PR; GitHub blocks formal self-approval)

精确评审头（Exact Head）: 3274@0eb251fe5046bcf59b26d7f38cac2d98afb657a7
Base: main | 类型: Agent workspace 提升 + latest-main merge sync
作者: huangruiteng（owner；多贡献者合入）

详细中文评审

动机

作者在已批准的 d030e6639（CLI 差分修复）之上再次同步最新 main（含已合并的 #3272/#3273），产生 merge head 0eb251fe5。评审目标是确认 merge sync 未引入新问题、PR 自身内容保持已批准状态。

改动思路

merge sync latest main：PR 自身 commit 序列不变（status hot-path 修复 d030e6639 保留），新增内容来自已合并的 #3272/#3273（与 PR 无关）。git log origin/main..origin/pr-3274c-head 显示 PR 专属提交仍为 workspace 提升 + status 修复 + merge sync。

具体改动

merge sync + 上一轮已批准的 status hot-path 收敛；PR 功能面不变（Manager/Goal workspace、受限 router、Preview/Apply 安全边界、Session 投影）。

关键内容讲解

  1. 内容保持：PR 专属 diff 仍包含 public_boundary_scan 移出 hot path 的修复（差分 smoke 此前已 PASS）。
  2. merge 干净：新增内容仅为已合并的 #3272/#3273 包；无 PR 专属新代码漂移。
  3. 检查状态：Sign-off、dependency-review SUCCESS；build ×2、pytest IN_PROGRESS（无失败）。

对主干的风险

无阻断项。CI 无失败；合并前确认 build/pytest 完成且绿即可。

验证矩阵（exact head 实测/CI）

场景 结果
PR 专属内容 vs 已批准头 一致（status 修复保留；新增为 merge sync）
Sign-off / dependency-review SUCCESS
build ×2 / pytest（CI） IN_PROGRESS（评审时刻，无失败）

我的整体评价

merge sync 干净、已批准修复保留、CI 无失败；无需新的内容审查。结论：APPROVE（author-owned PR，以 COMMENTED 记录批准结论；合并前确认 CI 绿）。

English Verdict

Verdict: APPROVE (author-owned PR; recorded as COMMENTED because GitHub blocks formal self-approval). This head is a clean latest-main merge sync on top of the already-approved status hot-path fix; the PR-specific content is unchanged and the differential fix is retained. Sign-off and dependency-review are green, and CI build/pytest were still in progress with no failures at review time.

@maxliux5

maxliux5 commented Aug 16, 2026

Copy link
Copy Markdown
Collaborator Author

Promotion blocker resolved — exact head 0eb251fe

The previous CLI-output P1 is fixed in d030e663: the status hot path keeps the human-readable boundary check while the detailed public_boundary_scan remains available from the canonical loopx check contract.

Validation:

  • remote Qualify agent-facing CLI output: PASS
  • remote full pytest: PASS (10m37s) on the blocker-fix head
  • local exact CLI base/head differential after latest-main integration: PASS
  • focused status and latest-main benchmark tests: 29 passed
  • loopx-repo-health offline contract smoke: PASS
  • dashboard build with Node 22.22.2: PASS
  • DCO, dependency review, and release build: PASS

Latest origin/main changes from #3272 and #3273 are integrated cleanly in isolated signed-off commit 0eb251fe; the branch is 0 commits behind main. A new CI round is running for this exact head.

Final UI/CUA evidence remains applicable because the post-CUA changes only narrow status JSON diagnostics and integrate non-dashboard mainline benchmark/package commits. The last real Chrome CUA pass covered Manager Overview → transient answer → full Chat → Overview, authoritative Session 已完成 / 1/1, default ↔ Beast theme, and 110% zoom with P0/P1/P2 = 0.

Latest default-theme first screen:

Latest LoopX personal workspace

@huangruiteng please re-review the exact head after the new checks finish.

@huangruiteng

huangruiteng commented Aug 16, 2026 via email

Copy link
Copy Markdown
Owner

@huangruiteng

huangruiteng commented Aug 16, 2026 via email

Copy link
Copy Markdown
Owner

@maxliux5

maxliux5 commented Aug 17, 2026

Copy link
Copy Markdown
Collaborator Author

我解决一下，怎么还有本地地址了

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@huangruiteng huangruiteng huangruiteng left review comments
@steven-kid steven-kid Awaiting requested review from steven-kid steven-kid is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@maxliux5 @huangruiteng