Repository navigation
fix(snapshot): upload Central snapshot files serially - #312
Merged
Merged
Conversation
-T 1 still lets Resolver put one module's artifacts and checksums in parallel, and a lowered retry cap drops HTTP 429 when Retry-After is longer. Serialize uploads and retry the deploy after Cloudflare 1015.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-T 1did not stop Central Portal rate limiting. Resolver still uploads one module's JAR, POM, sources, Javadoc, and checksums on five threads (aether.connector.basic.parallelPut=true).jfoundry-webchecksums. The module failed in about five seconds, so the HTTP retry did not wait.Retry-Afteris aboveaether.transport.http.retryHandler.intervalMax. The previous change lowered that cap from the 300000 ms default to 120000 ms.Validation
bash scripts/verify-supply-chain-workflows-test.shbash scripts/verify-workflow-paths.shbash -non the publish scriptImpact
Rerunning run 43351097131 still uses the merged workflow. After this reaches
main, start Snapshot manually to publish1.8.0-SNAPSHOT.