add support for abstract namespace unix sockets - #331
Open
programmerlexi wants to merge 1 commit into
Open
Conversation
Owner
|
Thanks for the PR! This might be a bit too Linux-specific. Mostly a concern for the far future when we finally expand support to other OSes though. I'll give this some testing when I have time (I don't use named sockets myself). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to my testing this should work.
I haven't run cargo fmt on this as doing so reformats the entire source tree.
The covers seem to be missing, but i don't know why that is, they exist when i use rmpc.
This was a pain to test because i use nixos and gtk doesn't like that and needs wrapGAppsHook to work, but i haven't bothered to make that work with naersk, so i had to rebuild the entire project and all dependencies every time i changed something (~8m on my machine per build).
Implements and closes #104