Closed
Conversation
Signed-off-by: Adrian Tanase <atanase@adobe.com>
…size - Remove unused StructArray import - Replace unwrap() with ok().flatten() on sum_array_checked to avoid panic on arithmetic overflow - Clamp negative i64 to 0 before casting to usize
|
ACTION NEEDED delta-rs follows the Conventional Commits specification for release automation. The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. |
radustoenescu
changed the title
radustoenescu
force-pushed
the
skip-stats-rebased
branch
3 times, most recently
from
ed354ef to
b636501
Compare
radustoenescu
changed the title
aditanase
approved these changes
Apr 21, 2026
| predicate: Option<PredicateRef>, | ||
| ) -> SendableRBStream { | ||
| let scan = match self.scan_builder().with_predicate(predicate).build() { | ||
| let scan = match self.scan_builder().with_predicate(predicate).with_skip_stats(true).build() { |
Collaborator
There was a problem hiding this comment.
Wondering if we should byte the bullet and add a config option on the TableConfig so we can change this at runtime. Fine to have the default on false but maybe some queries end up benefitting from stats
| fn read_adds_size(array: &dyn ProvidesColumnByName) -> usize { | ||
| if let Some(size) = ex::extract_and_cast_opt::<Int64Array>(array, "size") { | ||
| sum_array_checked::<arrow::array::types::Int64Type, _>(size).unwrap().unwrap_or_default() as usize | ||
| sum_array_checked::<arrow::array::types::Int64Type, _>(size) |
Collaborator
There was a problem hiding this comment.
please find the originating commit and try a fixup on it + force push once this PR gets in, that will make the rebase process simpler
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
skip_statsbehavior from delta-kernel 0.20 to skipstats_parsedcheckpoint deserialization for wide-table snapshot speedups (with documented trade-off that limit-based file pruning becomes a no-op when stats are absent)read_adds_sizeagainst overflow/invalid values by removing panic paths and clamping negative sums beforeusizecast