Skip to content

Merge configCosmosKernel.h into configCosmos.h #83

Description

@ejpilger

With the repo split into thirdparty, kernel, micro-agent, simulator, agent, and ground-station, the distinction between configCosmos.h and configCosmosKernel.h is no longer meaningful.

Current situation:

  • configCosmosKernel.h — platform detection, standard C++ headers, STL types, using declarations
  • configCosmos.h — includes configCosmosKernel.h, then adds mutex/thread/condition_variable, OS-specific socket/network headers, and json11.hpp

Why the distinction is now redundant:

  • json11.hpp is on the include path via the thirdparty repo — no need to pull it in through a config header
  • Socket/network headers are included directly by socketlib.h in the micro-agent repo
  • Threading headers (<thread>, <mutex>) can be included by the individual files that need them
  • The repo boundary itself enforces what is available at each layer — that was the original purpose of having two config headers

Fix:

  1. Merge the content of configCosmosKernel.h into configCosmos.h (keep the kernel content, drop the now-redundant additions)
  2. Update all #include "support/configCosmosKernel.h" references to #include "support/configCosmos.h" across all repos
  3. Remove configCosmosKernel.h

Scope: All six repos (thirdparty, kernel, micro-agent, simulator, agent, ground-station) and core.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions