Skip to content

Tasks are added to without any upper bound #71

Description

@ginoscott

The Task::Add() function appends to the back of the tasks vector without any upper limit. It would be better to enforce an upper limit and also check for any open slots in the current allocated slots.

int32_t Task::Add(string command, string node, float timeout)
{
mtx.lock();
tasks.resize(tasks.size()+1);
tasks.back().startmjd = currentmjd();
tasks.back().state = 0;
tasks.back().command = command;
tasks.back().timeout = timeout;
const int32_t task_identifier = decisec(tasks.back().startmjd);
if (node.empty())
{
tasks.back().path = data_base_path(NodeName, "temp", AgentName, data_name(tasks.back().startmjd, "task", NodeName, AgentName));
}
else
{
tasks.back().path = data_base_path(node, "temp", AgentName, data_name(tasks.back().startmjd, "task", NodeName, AgentName));
}
mtx.unlock();
return task_identifier;
}

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions