Use minify_html instead of htmlmin - #195
Merged
Merged
Conversation
Contributor
Author
|
While a PR supporting Python 3.13 for minify-html has been merged, a new release of the wheel has not yet been created. |
Owner
|
@danzou56 , Thanks a lot for providing the fix to support Python 3.13. We created a release candidate to be able to test the report implementation is not altered when using the new HTML minimizer: https://test.pypi.org/project/behavex/4.1.2rc1/ Hernan |
Owner
|
Hi @danzou56. Please, use the following RC: https://test.pypi.org/project/behavex/4.1.2rc4/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
#186
Behavex cannot be installed with python 3.13 because behavex depends on the remove cgi module via htmlmin to perform HTML minification.
Proposed solution
While the change to remove cgi from htmlmin is small, htmlmin hasn't been updated since Python 3.2/8 years ago, so it may not be reasonable to expect the maintainer to merge the pull request. Instead of relying on htmlmin, replace it with minify-html.
Behavex currently passes in
preandtextareaas tags to exclude from minification. Likewise, minify-html does not remove whitespace inpreandtextareaout of the box<pre>elementspreandtextareaelements (HTML entity 32 is a space character)