Repository navigation
Keep existing vulnerabilities in the issue, not a red main - #47
Merged
Merged
Conversation
A run on main that failed while any vulnerability remained would turn every commit red in about 50 repositories and send a failure email each day, on top of the tracking issue that already records them. Runs on main now stay green once the issue is current, and fail only on scanner or API errors. A pull request still fails when it adds a vulnerability. A manual run on another branch, or a repository with issues turned off (two forks), still fails while vulnerabilities remain, because nothing else would record them. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
main(lockfile push, daily schedule, manual run), the audit now stays green once thedependency-auditissue is current, and fails only on scanner or API errors. Failing while any vulnerability remained would have turned every commit red in about 50 repositories and sent a failure email each day, on top of the issue that already records them.Test plan
node --test actions/dependency-audit/index.test.mjs(16 pass, including the issues-disabled and branch cases)python3 -m unittest discover -s testswith PyYAMLGenerated with Devin