Repository navigation
fix: restore compatibility with current DeepSeek Harness (0.2.2) - #2
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is by an automated agent, not a human.
Summary
Restores dsh-memory on the current DeepSeek Harness (
0.2.2-alpha.2). Version 0.1.4 made the whole Web UI fail to start because its Bundle patch still required a service that current DSH no longer provides. This PR fixes the Bundle composition, aligns the affected Host API calls, and ships regression evidence.Refs #1. Not merged or published, per the issue request.
Root cause
cordis.patch.ymloverrode the standardconnectionrow withinject: [webRuntime, webServer]. Current DSH:webRuntimeservice, soconnectionwaited forever and Web aborted withconnection (required) missing webRuntime;webStartupfor that row'strustedHostsconfig, which the override dropped;webServerfrom the Connection provider context forconnection.rpc.handle().Removing the override alone is also insufficient: the memory RPC child then fails with
cannot get property "webServer" without inject, and/memory/statusreturns HTTP 405.Changes
cordis.patch.yml: injectwebStartup(row config) andwebServer(generic RPC registration) into the standard Connection row.src/index.ts/src/host-contracts.ts: use the current two-argumentconnection.rpc.handle(channel, handler); the channel now follows Connection's standard Host/Origin and browser-auth fence instead of an unsupported per-channel authority option.src/consolidation-worker.ts/src/dsh-runtime.d.ts: use the current one-argumentinstallModelSelection(agentCtx).package.json: remove the no-longer-existing@deepseek-ai/dsh-client-runtimefromdsh.client.inject; bump to 0.1.5.Verification
pnpm run check— typecheck, 122 tests (19 files), and build pass.node scripts/check-memory-rpc.mjs <dsh-checkout>—unpatched: passed,patched: passed,headless: passed.checkpassed ford9a1a5a.DSH_HOMEunder a temp dir) installed the packed 0.1.5 tarball:--dump-configshowsinject: [webStartup, webServer];__DSH_BOOT__includes@hr98w/dsh-memoryand the client bundle is served as JavaScript;/memory/status,global/read,global/replace(commit and stale-revision conflict) respond correctly.Before
Shipped v0.1.4 on DSH 0.2.2-alpha.2 (actual baseline)
Web startup aborts, so no page can render; there is no rendered “before” screenshot to capture:
Supporting diagnostic — removing the stale override alone
Not the shipped baseline; shows why
webServermust still be injected. Memory loads but its RPC channel is never registered (transport failure ... HTTP 405).After
0.1.5 on DSH 0.2.2-alpha.2; same viewport, theme, and zh-CN locale, Memory page enabled and loading data over the RPC channel:
Limitations
no-changeagainst the real Host.inject. A future DSH row-dependency change is not merged automatically; the real-DSH check pins the patched list to the current bundle dependencies pluswebServerand fails on drift instead of silently dropping a dependency.