chore: drop unused funcs1ArgD declarations; clear stale TODO on derivative maps#40
Draft
hozblok wants to merge 1 commit into
Draft
chore: drop unused funcs1ArgD declarations; clear stale TODO on derivative maps#40hozblok wants to merge 1 commit into
hozblok wants to merge 1 commit into
Conversation
…ative maps
Audit of the three maps the TODO questioned:
functionsTwoArgsDLeft USED — default arg to calculate_derivative; defined
in cseval.cpp and cseval_complex.cpp
functionsTwoArgsDRight USED — same
funcs1ArgD UNUSED — declared in both headers, never defined,
never referenced anywhere else in src/cpp
Delete the two unused `funcs1ArgD` static-member declarations (one in
cseval.hpp, one in cseval_complex.hpp). Drop the "TODO: delete me?"
question from cseval.hpp's comment now that the audit answered it.
No behavior change. Full suite 388/388 (3 xfailed unchanged).
Closes TODO src/cpp/cseval/cseval.hpp:311.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes TODO
src/cpp/cseval/cseval.hpp:311(// names: TODO: delete me?).Audit
The comment questioned three static-member maps. Grep across the whole tree:
functionsTwoArgsDLeftcalculate_derivative(...)in bothcseval.hpp/cseval_complex.hpp; defined in the matching.cppfiles.functionsTwoArgsDRightfuncs1ArgDcseval.hpp:314andcseval_complex.hpp:316, never defined, never referenced anywhere else undersrc/cpp/.Change
funcs1ArgDstatic-member declarations (one real, one complex).TODO: delete me?fromcseval.hpp's comment now that the audit answered it.functionsTwoArgsDLeft/functionsTwoArgsDRight— they're load-bearing.No behavior change. Full suite 388/388 (3 xfailed unchanged).