Repository navigation
fix: restore browser workflows with current HowlFrame - #13
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The browser showed “Cannot reach the mission API” while the API and backend suite worked: compiled fetch helpers expected Node globals. This consumer now declares only a browser network grant, chooses the explicit JavaScript build target, wraps long blocker reasons on mobile, and rejects scalar dependency inputs without masking server faults.
Depends on howlcipher/howlframe#132 for the browser runtime fix. Verified together with Frame commit 48771e5c. The published demo is regenerated from .howl and declares the same network-only host grant.
Verification: the old browser emitted no API request and the new browser smoke failed against it. Candidate backend contracts, documentation, SEO and browser-script lint pass. Playwright desktop 1280px/mobile 390px checks actual mission rendering, API200, no page errors, no horizontal overflow, and keyboard focus; screenshots retained in mission evidence. Existing tests protect malformed map/string/mixed-list inputs and valid/omitted/empty arrays. Added tests protect scalar errors with error/reason/field and null-as-empty behavior, with fixture cleanup. Claude independent review returned CLEAN after replacing the broad catch with narrow input validation and checking existing coverage. CI passes on the published branch.
Test impact: public browser loading and current compiler target compatibility were previously unprotected by backend tests alone. New browser smoke is read-only and requires an isolated running instance plus Playwright/Chromium; it is a smoke check, not full accessibility certification. No authority/state-transition policy was changed.