Repository navigation
fix(assisted): legacy revalidated handoffs keep their confirm control - #37
Merged
Merged
Conversation
actionForRevalidation's application_ready case gated RequiresExplicitSubmit on a literal AWAITING_REVIEW check, so a BLOCKED_CAPTCHA- or MANUAL_REQUIRED-origin job that was submitted directly in the assisted browser (skipping the guided Continue step) lost its "I saw a confirmation — Mark Applied" control once the browser closed, even though ConfirmAssistedSubmission itself already accepts all three eligible statuses. Found live during the dogfood run when a genuinely submitted BLOCKED_CAPTCHA-origin application (Wurl, job 1240) had no way back to confirmation. Gate on isAssistedEligibleStatus(status) instead, matching the backend predicate this control is supposed to front for. Updates the existing test that had asserted the now-falsified assumption that a CAPTCHA-origin job never has a submittable form. bugs.md #557 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Cohort advanced 3/5 -> 4/5 after rebuilding and restarting the dashboard binary against the fix and confirming the real prior Wurl submission through the now-restored control. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
actionForRevalidation'sapplication_readycase gatedRequiresExplicitSubmiton a literalstatus == "AWAITING_REVIEW"check, so aBLOCKED_CAPTCHA- orMANUAL_REQUIRED-origin job that got submitted directly in the assisted browser (skipping the guided Continue step) lost its "I saw a confirmation — Mark Applied" control once the browser closed — even thoughConfirmAssistedSubmissionitself already accepts all three eligible statuses.BLOCKED_CAPTCHA-origin application (Wurl, job 1240) had no way back to confirmation.isAssistedEligibleStatus(status)instead, matching the backend predicate this control fronts for.documentation/backlog_history/bugs_done_details.md.Test plan
go build ./...,go vet ./...,gofmt -l ./cmd ./pkg ./internalcleango test ./...passes exceptTestServeKnowledgeProfile_KeepsBackupsBoundedAndPrivate, confirmed pre-existing/unrelated onmainTestActionForRevalidation_EligibleStatusesAllowConfirmation,TestActionForRevalidation_IneligibleStatusUnchangedapplications.db: rebuilt/restarted the dashboard binary, Wurl's card regained the confirm control, operator clicked it for a real prior Greenhouse submission, dogfood cohort advanced 3/5 → 4/5 with no duplicate row🤖 Generated with Claude Code