Repository navigation
Fix npm 10 clean installs after approved PR integration - #142
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The approved DEV lockfile carried into #141 was generated with npm 12. GitHub CI uses Node 22/npm 10, whose
npm cirejected the incomplete transitive dependency graph before any application tests ran.Regenerate the lockfile using the already installed Node 22.22.0/npm 10.9.4. This adds the missing dependency entries required by app-builder-lib's @electron/get 3.x tree. No package.json changes or changes to existing package versions, artifact URLs, or integrity hashes are included.
Validation:
npm ci --dry-run --ignore-scripts --no-audit --no-fundpassed with npm 10.9.4;git diff --checkpassed. No dependencies were installed and no lifecycle scripts were executed for this repair. The DEV application build passed before this lockfile-only change. Application tests and platform UI checks were not run locally.This is a maintainer integration fix; the original contributor commits and acknowledgments in #141 remain unchanged.