feat(controls): add copy on selection setting - #116
Conversation
|
Reviewed head The off-by-default setting, persistence, card/fullscreen propagation, and Shift selection support are useful. There is one behavior issue to fix before merging. P2: An ordinary TUI click can overwrite the clipboard with an old selectionIn Concrete sequence:
xterm's selection service is disabled while mouse reporting is active. Its Please tie copying to a selection gesture actually accepted by xterm, rather than any click followed by a non-empty selection. Comparing only selected strings is insufficient: a new legitimate selection of the same text should still copy. Add a behavioral regression check for an unchanged retained selection plus a normal TUI click, alongside a genuine Shift-selection case. Preserve selection completion when releasing outside the screen and cancellation/disposal behavior. Integration with current mainAn actual Git merge rehearsal finds a conflict in The existing CI is green for this head, but it predates the recently merged changes. Please resolve against current main and rerun CI on that resulting head. Review method: source tracing, including the installed xterm 6.0.0 selection implementation, and Git merge checks. I did not run local tests or reproduce the scenario in the UI. |
# Conflicts: # src/renderer/src/features/terminal/terminalMouseCoordinates.ts
|
@howdeploy The PR head is now merged with the current What changed:
Validation on the resulting head:
Fresh GitHub CI is running for this head. |
|
Follow-up review of The reported retained-selection clipboard overwrite is addressed: the helper now requires an xterm selection-change event during the gesture/completion interval, and TerminalCard disposes that subscription. The mouse-coordinate integration preserves main's scoped listeners and endDrag cleanup. Both new regression checks passed in the Linux and Windows CI logs. The previous merge conflict is resolved. The remaining CI failures are separate:
Please sync with main once #118 lands and obtain a green run on the resulting head. The original clipboard finding is closed; the current red checks remain the merge blocker. Source/CI-log review only; no local tests or UI checks were run. |
Summary
Copy on selectioncontrol setting.Validation
npm run buildpassed.