Clean stop timetable edition

[vpassama]

Because Mtt doesn't provide anymore the function 'edit a stopPoint', some cleaning is needed.

[vpassama]

Hi,

I have some problems with the FrequencyControllerTest result :

1) CanalTP\MttBundle\Tests\Functional\Controller\FrequencyControllerTest::testEditForm
Failed asserting that false is true.

When I check the html content :

public function testEditForm() {
    [...]
    echo $crawler->text()
    $this->assertTrue($crawler->filter('html:contains("' . $content . '")')->count() > 0);
}

I see that the result is returning an error :

Navitia\Component\Exception\NotFound\UnknownObjectException: Navitia error message: The region fr-cen doesn't exists
    at n/a
        in /var/www/nmm-merge/vendor/canaltp/navitia/NavitiaExceptionFactory.php line 44

    at Navitia\Component\NavitiaExceptionFactory->create('404', 'unknown_object', 'The region fr-cen doesn't exists')
        in /var/www/nmm-merge/vendor/canaltp/navitia/Service/NavitiaService.php line 231

    at Navitia\Component\Service\NavitiaService->errorProcessor('{"message":"The region fr-cen doesn't exists","error":{"message":"The region fr-cen doesn't exists","id":"unknown_object"}}', '404')
        in /var/www/nmm-merge/vendor/canaltp/navitia/Service/NavitiaService.php line 172

    at Navitia\Component\Service\NavitiaService->callApi(object(CoverageRequest), null)
        in /var/www/nmm-merge/vendor/canaltp/navitia/Service/NavitiaService.php line 75

    at Navitia\Component\Service\NavitiaService->process(array('api' => 'coverage', 'parameters' => array('region' => 'fr-cen', 'path_filter' => 'routes/route:TTR:Nav155', 'parameters' => '?depth=3')), null, '5000', true)

[vpassama]

Something is broken in the left_menu when editing a stopTimetable.

There is a link to preview page but no externalStopPointId is provided. Maybe we should provide the 'first' stopPoint on the route to this menu ?

[vpassama]

I'm currently working on the pdf generation. It would be great to deploy a new 'line-timetable' branch in https://github.com/CanalTP/AmqpMttWorkers because some changes are needed.

[vpassama]

I have a failure in TimetableControllerTest.php :

Starting test 'CanalTP\MttBundle\Tests\Functional\Controller\TimetableControllerTest::testAccess'.
PHP Fatal error:  Call to a member function getCustomer() on a non-object in /var/www/nmm-merge/vendor/canaltp/mtt-bundle/Controller/StopTimetableController.php on line 133

https://github.com/CanalTP/MttBundle/blob/line-timetable/Tests/Functional/Controller/TimetableControllerTest.php#L116-L121

I don't know if I really broke something here. When I try to access this view when I'm not logged in, I have the same error.

[dvdn]

As we spoke about AmqpMttWorkers, a new branch is available :
https://github.com/CanalTP/AmqpMttWorkers/tree/line-timetable

[vpassama]

👍

[vpassama]

Hey @dvdn, as said before :

Something is broken in the left_menu when editing a stopTimetable.

There is a link to preview page but no externalStopPointId is provided. Maybe we should provide the > 'first' stopPoint on the route to this menu ?

Something is broken between edition and preview in the left_menu. Do you want me to fix this ?

[kun2985]

You deleted the parametre "stopPointLevel" there, but this parametre is not deleted in the file "/Resources/views/Layouts/timegrid.html.twig".

[vpassama]

Right but is this file really used somewhere ?

[kun2985]

I use your template https://github.com/Tisseo/MttTemplate to test.
I found that there is some probleme in the template compared with the pr:

• stop.html.twig
  • at line 63 the macro is not exist: {{ macros.notes(notes, notesType) }}
  • at line 76 include "CanalTPMttBundle:Layouts:common.js.twig" should be "common.html.twig"
  • at line 76 include "CanalTPMttBundle:Layouts:common.html.twig" without the parameter "timetable" who is used in the file "common.html.twig"
• /mtt-bundle/Resources/public/js/layout.js
  • at line 41 "'blockType': $(this).data('type')" should be "'blockType': $(this).data('block-type')"

[vpassama]

Yes, https://github.com/Tisseo/MttTemplate is not maintained anymore because of the lack of time. You should just use the default templates provided by fixtures.

[kun2985]

I can't find a template for lines. I have defaults templates for stops in the project. What do you mean "the default templates provided by fixtures"?

[kun2985]

Can you tell me where to find the link to view "page to edit a simple timecard" for a line.

[vpassama]

This PR isn't about line timetable edition, it just clean the code from stopPoint edition functions. If you want a default template for lines, you should checkout the next PR : #90