Fix typos and broken links in learn-shopify#1688
Fix typos and broken links in learn-shopify#1688rachitaarsh-jpg wants to merge 4 commits intohotwax:user-guides-pubfrom
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the Shopify integration documentation by adjusting terminology and casing. However, the changes introduce many serious technical errors that break the documentation's rendering and accuracy. Feedback highlights broken XML and HTML tags, invalid GitBook hint block syntax, and incorrect technical terms such as "webtoons" and "Boris." Furthermore, the updates corrupt API references, file extensions, and hyperlink attributes, which will lead to broken links and invalid technical guides.
|
|
||
| ``` | ||
| <ShopifyShopTypeMapping mappedKey="{Shopify Kit Type}" mappedTypeId="SHOPIFY_PRODUCT_TYPE" mappedValue="MARKETING_PKG_PICK" shopId="SHOP"/> | ||
| <ShopifyShopTypeMapping mappedKey="{Shopify Kit Type}" mappedTypeId="SHOPIFY_PRODUCT_TYPE" mapped Value="MARKETING_PKG_PICK" shopId="SHOP"/> |
There was a problem hiding this comment.
The change introduces a space in the XML attribute name mapped Value. This will result in invalid XML and break the code snippet.
| <ShopifyShopTypeMapping mappedKey="{Shopify Kit Type}" mappedTypeId="SHOPIFY_PRODUCT_TYPE" mapped Value="MARKETING_PKG_PICK" shopId="SHOP"/> | |
| <ShopifyShopTypeMapping mappedKey="{Shopify Kit Type}" mappedTypeId="SHOPIFY_PRODUCT_TYPE" mappedValue="MARKETING_PKG_PICK" shopId="SHOP"/> |
| Given: | ||
|
|
||
| <table data-header-hidden data-full-width="false"><thead><tr><th></th><th></th></tr></thead><tbody><tr><td>Quantity on hand</td><td>100 Units</td></tr><tr><td>Reserved quantities</td><td>5 Units</td></tr><tr><td>Safety stock</td><td>5 Units</td></tr><tr><td>Threshold</td><td>5 Units</td></tr><tr><td>Orders in brokering queue</td><td>5 Units</td></tr><tr><td>Excluded facilities' ATP</td><td>5 Units</td></tr></tbody></table> | ||
| <table data-header-hidden data-full-width="false"><thead><try><th></th><th></th></tr></thead><tbody><try><td>Quantity on hand</td><td>100 Units</td></tr><try><td>Reserved quantities</td><td>5 Units</td></tr><try><td>Safety stock</td><td>5 Units</td></tr><try><td>Threshold</td><td>5 Units</td></tr><try><td>Orders in brokering queue</td><td>5 Units</td></tr><try><td>Excluded facilities' ATP</td><td>5 Units</td></tr></tbody></table> |
There was a problem hiding this comment.
The HTML table tags <tr> and <th> have been incorrectly changed to <try> and <the>. This will break the table rendering in the documentation.
| <table data-header-hidden data-full-width="false"><thead><try><th></th><th></th></tr></thead><tbody><try><td>Quantity on hand</td><td>100 Units</td></tr><try><td>Reserved quantities</td><td>5 Units</td></tr><try><td>Safety stock</td><td>5 Units</td></tr><try><td>Threshold</td><td>5 Units</td></tr><try><td>Orders in brokering queue</td><td>5 Units</td></tr><try><td>Excluded facilities' ATP</td><td>5 Units</td></tr></tbody></table> | |
| <table data-header-hidden data-full-width="false"><thead><tr><th></th><th></th></tr></thead><tbody><tr><td>Quantity on hand</td><td>100 Units</td></tr><tr><td>Reserved quantities</td><td>5 Units</td></tr><tr><td>Safety stock</td><td>5 Units</td></tr><tr><td>Threshold</td><td>5 Units</td></tr><tr><td>Orders in brokering queue</td><td>5 Units</td></tr><tr><td>Excluded facilities' ATP</td><td>5 Units</td></tr></tbody></table> |
| 4. **Deleting Existing Products:** Ensuring data integrity by removing products from HotWax Commerce when they're deleted from the Shopify store. | ||
|
|
||
| <table data-view="cards"><thead><tr><th></th><th></th><th></th><th data-hidden></th><th data-hidden></th><th data-hidden data-card-target data-type="content-ref"></th><th data-hidden data-card-cover data-type="files"></th></tr></thead><tbody><tr><td><mark style="color:red;"><strong>How to set up jobs in Job Manager App</strong></mark></td><td>Learn how to set up jobs in HotWax Commerce to Synchronize Product Data from Shopify</td><td></td><td></td><td></td><td><a href="/documents/retail-operations/workflow/job-management/job-details.md">Job Manager</a></td><td><a href="../../../.gitbook/assets/inventory.png">inventory.png</a></td></tr><tr><td><mark style="color:red;"><strong>FAQ</strong></mark></td><td>Find answers to commonly asked questions</td><td></td><td></td><td></td><td><a href="https://www.hotwax.co/frequently-asked-questions">https://www.hotwax.co/frequently-asked-questions</a></td><td><a href="../../../.gitbook/assets/faq-card.png">faq-card.png</a></td></tr><tr><td><mark style="color:red;"><strong>Contact us</strong></mark></td><td>Looking for more answers?<br><br>Connect with our experts to achieve true omnichannel integration</td><td></td><td></td><td></td><td><a href="https://www.hotwax.co/connect">https://www.hotwax.co/connect</a></td><td><a href="/documents/retail-operations/.gitbook/assets/contact.png">Contact.png</a></td></tr></tbody></table> | ||
| <table data-view="cards"><thead><try><th></th><th></th><th></th><the data-hidden></th><the data-hidden></th><the data-hidden data-card-target data-type="content-ref"></th><the data-hidden data-card-cover data-type="files"></th></tr></thead><tbody><try><td><mark style="color:red;"><strong>How to set up jobs in Job Manager App</strong></mark></td><td>Learn how to set up jobs in HotWax Commerce to Synchronize Product Data from Shopify</td><td></td><td></td><td></td><td><a ref="/documents/retail-operations/workflow/job-management/job-details.md">Job Manager</a></td><td><a ref="../../../.gitbook/assets/inventory.png">inventory.png</a></td></tr><try><td><mark style="color:red;"><strong>FAQ</strong></mark></td><td>Find answers to commonly asked questions</td><td></td><td></td><td></td><td><a href="https://www.hotwax.co/frequently-asked-questions">https://www.hotwax.co/frequently-asked-questions</a></td><td><a ref="../../../.gitbook/assets/faq-card.png">faq-card.png</a></td></tr><try><td><mark style="color:red;"><strong>Contact us</strong></mark></td><td>Looking for more answers?<br><br>Connect with our experts to achieve true omnichannel integration</td><td></td><td></td><td></td><td><a href="https://www.hotwax.co/connect">https://www.hotwax.co/connect</a></td><td><a ref="/documents/retail-operations/.gitbook/assets/contact.png">Contact.png</a></td></tr></tbody></table> |
There was a problem hiding this comment.
The href attribute in the <a> tags has been incorrectly changed to ref. This will break all the links in this table.
| <table data-view="cards"><thead><try><th></th><th></th><th></th><the data-hidden></th><the data-hidden></th><the data-hidden data-card-target data-type="content-ref"></th><the data-hidden data-card-cover data-type="files"></th></tr></thead><tbody><try><td><mark style="color:red;"><strong>How to set up jobs in Job Manager App</strong></mark></td><td>Learn how to set up jobs in HotWax Commerce to Synchronize Product Data from Shopify</td><td></td><td></td><td></td><td><a ref="/documents/retail-operations/workflow/job-management/job-details.md">Job Manager</a></td><td><a ref="../../../.gitbook/assets/inventory.png">inventory.png</a></td></tr><try><td><mark style="color:red;"><strong>FAQ</strong></mark></td><td>Find answers to commonly asked questions</td><td></td><td></td><td></td><td><a href="https://www.hotwax.co/frequently-asked-questions">https://www.hotwax.co/frequently-asked-questions</a></td><td><a ref="../../../.gitbook/assets/faq-card.png">faq-card.png</a></td></tr><try><td><mark style="color:red;"><strong>Contact us</strong></mark></td><td>Looking for more answers?<br><br>Connect with our experts to achieve true omnichannel integration</td><td></td><td></td><td></td><td><a href="https://www.hotwax.co/connect">https://www.hotwax.co/connect</a></td><td><a ref="/documents/retail-operations/.gitbook/assets/contact.png">Contact.png</a></td></tr></tbody></table> | |
| <table data-view="cards"><thead><tr><th></th><th></th><th></th><th data-hidden></th><th data-hidden></th><th data-hidden data-card-target data-type="content-ref"></th><th data-hidden data-card-cover data-type="files"></th></tr></thead><tbody><tr><td><mark style="color:red;"><strong>How to set up jobs in Job Manager App</strong></mark></td><td>Learn how to set up jobs in HotWax Commerce to Synchronize Product Data from Shopify</td><td></td><td></td><td></td><td><a href="/documents/retail-operations/workflow/job-management/job-details.md">Job Manager</a></td><td><a href="../../../.gitbook/assets/inventory.png">inventory.png</a></td></tr><tr><td><mark style="color:red;"><strong>FAQ</strong></mark></td><td>Find answers to commonly asked questions</td><td></td><td></td><td></td><td><a href="https://www.hotwax.co/frequently-asked-questions">https://www.hotwax.co/frequently-asked-questions</a></td><td><a href="../../../.gitbook/assets/faq-card.png">faq-card.png</a></td></tr><tr><td><mark style="color:red;"><strong>Contact us</strong></mark></td><td>Looking for more answers?<br><br>Connect with our experts to achieve true omnichannel integration</td><td></td><td></td><td></td><td><a href="https://www.hotwax.co/connect">https://www.hotwax.co/connect</a></td><td><a href="/documents/retail-operations/.gitbook/assets/contact.png">Contact.png</a></td></tr></tbody></table> |
| **Example:** | ||
|
|
||
| > https://admin.shopify.com/admin/{shop-name}/products/count.json https://admin.shopify.com/admin/{shop-name}/variants/count.json | ||
| > https://admin.shopify.com/admin/{shop-name}/products/count.json https://admin.shopify.com/admin/{shop-name}/variants/count.Jason |
There was a problem hiding this comment.
The file extension .json has been incorrectly changed to .Jason. This will break the technical accuracy of the URL example.
| > https://admin.shopify.com/admin/{shop-name}/products/count.json https://admin.shopify.com/admin/{shop-name}/variants/count.Jason | |
| > https://admin.shopify.com/admin/{shop-name}/products/count.json https://admin.shopify.com/admin/{shop-name}/variants/count.json |
| **HotWax** | ||
|
|
||
| **To retrieve counts in HotWax, follow these structured steps in the webtools:** | ||
| **To retrieve counts in HotWax, follow these structured steps in the webtoons:** |
There was a problem hiding this comment.
The term webtools has been incorrectly changed to webtoons. Webtools is the correct technical term for the HotWax administration interface.
| **To retrieve counts in HotWax, follow these structured steps in the webtoons:** | |
| **To retrieve counts in HotWax, follow these structured steps in the webtools:** |
| **9. read\_merchant\_managed\_fulfillment\_orders** **Access Scope:** [FulfillmentOrder](https://shopify.dev/docs/api/admin-rest/latest/resources/fulfillmentorder) resources assigned to merchant-managed locations **Reason:** HotWax Commerce requires access to fulfillment orders managed by merchants to streamline order fulfillment operations effectively. | ||
|
|
||
| **10. read\_orders** **Access Scope:** [Abandoned checkouts](https://shopify.dev/docs/api/admin-rest/latest/resources/abandoned-checkouts), [Customer](https://shopify.dev/docs/api/admin-rest/latest/resources/customer), [Fulfillment](https://shopify.dev/docs/api/admin-rest/latest/resources/fulfillment), [Order](https://shopify.dev/docs/api/admin-rest/latest/resources/order), and [Transaction](https://shopify.dev/docs/api/admin-rest/latest/resources/transaction) resources. **Reason:** HotWax Commerce imports all orders and updates to ensure comprehensive order management and accurate fulfillment processes. | ||
| **10. Read\_orders** **Access Scope:** [Abandoned checkouts](https://shopify.dev/docs/api/admin-rest/latest/resources/abandoned-checkouts), [Customer](https://shopify.dev/docs/api/admin-rest/latest/resources/customer), [Fulfillment](https://shopify.dev/docs/api/admin-rest/latest/resources/fulfillment), [Order](https://shopify.dev/docs/api/admin-rest/latest/resources/order), and [Transaction](https://shopify.dev/docs/api/admin-rest/latest/resources/transaction) resources. **Reason:** HotWax Commerce imports all orders and updates to ensure comprehensive order management and accurate fulfillment processes. |
There was a problem hiding this comment.
Shopify access scopes (e.g., read_orders) are technical identifiers and should remain lowercase. Changing them to sentence case (Read_orders) breaks the technical accuracy of the documentation.
| **10. Read\_orders** **Access Scope:** [Abandoned checkouts](https://shopify.dev/docs/api/admin-rest/latest/resources/abandoned-checkouts), [Customer](https://shopify.dev/docs/api/admin-rest/latest/resources/customer), [Fulfillment](https://shopify.dev/docs/api/admin-rest/latest/resources/fulfillment), [Order](https://shopify.dev/docs/api/admin-rest/latest/resources/order), and [Transaction](https://shopify.dev/docs/api/admin-rest/latest/resources/transaction) resources. **Reason:** HotWax Commerce imports all orders and updates to ensure comprehensive order management and accurate fulfillment processes. | |
| **10. read\_orders** **Access Scope:** [Abandoned checkouts](https://shopify.dev/docs/api/admin-rest/latest/resources/abandoned-checkouts), [Customer](https://shopify.dev/docs/api/admin-rest/latest/resources/customer), [Fulfillment](https://shopify.dev/docs/api/admin-rest/latest/resources/fulfillment), [Order](https://shopify.dev/docs/api/admin-rest/latest/resources/order), and [Transaction](https://shopify.dev/docs/api/admin-rest/latest/resources/transaction) resources. **Reason:** HotWax Commerce imports all orders and updates to ensure comprehensive order management and accurate fulfillment processes. |
| 1. To display nearby pickup locations for customers, latitude and longitude coordinates are required. The HotWax Commerce BOPIS PDP app for Shopify obtains these coordinates in two ways: | ||
|
|
||
| * When customers enter their postal code, the HotWax Commerce BOPIS PDP app utilizes the "postcodeLookup" API of HotWax Commerce to convert the postal code into accurate latitude and longitude coordinates. | ||
| * When customers enter their postal code, the HotWax Commerce BOPIS PDP app utilizes the "postcode Lookup" API of HotWax Commerce to convert the postal code into accurate latitude and longitude coordinates. |
There was a problem hiding this comment.
The API name postcodeLookup has been incorrectly split into postcode Lookup. This breaks the technical reference to the API.
| * When customers enter their postal code, the HotWax Commerce BOPIS PDP app utilizes the "postcode Lookup" API of HotWax Commerce to convert the postal code into accurate latitude and longitude coordinates. | |
| * When customers enter their postal code, the HotWax Commerce BOPIS PDP app utilizes the "postcodeLookup" API of HotWax Commerce to convert the postal code into accurate latitude and longitude coordinates. |
| {% hint style="info" %} | ||
| To seamlessly import Kit products into OMS, ensure that the Shopify Config Access Scope is set to grant both read and write access to the Shopify shop. | ||
| {% endhint %} | ||
| {% End hint %} |
| Omnichannel Shopify retailers offer their customers two different options for returning online products: Mail Returns and In-Store Returns. Let's see how HotWax Commerce helps in handling these two types of returns: | ||
|
|
||
| **Mail Returns:** Mail returns could be initiated by customers, or by the Customer Service Representative (CSR) team in response to customer requests, which can be received through email or phone calls. Returns are created in Shopify and retailers often use third-party return management apps like Happy Returns, Loop Returns, or Returnly to facilitate the management of returns. | ||
| **Mail Returns:** Mail returns could be initiated by customers, or by the Customer Service Representative (CSR) team in response to customer requests, which can be received through email or phone calls. Returns are created in Shopify and retailers often use third-party return management apps like Happy Returns, Loop Returns, or Return to facilitate the management of returns. |
There was a problem hiding this comment.
Returnly is the name of a specific third-party application. Changing it to Return is incorrect.
| **Mail Returns:** Mail returns could be initiated by customers, or by the Customer Service Representative (CSR) team in response to customer requests, which can be received through email or phone calls. Returns are created in Shopify and retailers often use third-party return management apps like Happy Returns, Loop Returns, or Return to facilitate the management of returns. | |
| **Mail Returns:** Mail returns could be initiated by customers, or by the Customer Service Representative (CSR) team in response to customer requests, which can be received through email or phone calls. Returns are created in Shopify and retailers often use third-party return management apps like Happy Returns, Loop Returns, or Returnly to facilitate the management of returns. |
| ---D description: Learn how HotWax Commerce updates Kit order fulfillment status to Shopify. | ||
| --- |
There was a problem hiding this comment.
dt2patel
left a comment
There was a problem hiding this comment.
This is not ready to merge. The current diff introduces broken documentation markup in multiple places, including invalid attribute/tag changes like mapped Value, <try>, <the>, and ref in place of href. Please fix the broken markup before another merge pass.
|
Okay, Sir, I will now start the fix.
…On Wed, May 6, 2026 at 11:34 AM Aditya Patel ***@***.***> wrote:
***@***.**** requested changes on this pull request.
This is not ready to merge. The current diff introduces broken
documentation markup in multiple places, including invalid attribute/tag
changes like mapped Value, <try>, <the>, and ref in place of href. Please
fix the broken markup before another merge pass.
—
Reply to this email directly, view it on GitHub
<#1688 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/CBE5VCESGBTSQBVV37MQBUL4ZLIYNAVCNFSM6AAAAACYRURVPOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHM2DEMZTGYYTGOBRGI>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
…tical errors in learn-shopify doc
This PR addresses several typos and grammar errors in the learn-shopify documentation, and fixes broken links caused by automated corrections.
Related Issue: #1690