[codex] migrate deprecated inventory endpoints#1398
Merged
ymaheshwari1 merged 1 commit intomainfrom May 7, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request migrates several API endpoints from the inventory-cycle-count prefix to the admin prefix and removes the unused loadStoresByFacility and loadUserFacilities actions. The review feedback recommends using encodeURIComponent for dynamic URL parameters to ensure robustness and notes a potential mismatch between partyId and userLoginId for the updated user facilities endpoint.
ymaheshwari1
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Business summary
This removes Inventory Count's remaining dependency on deprecated
inventory-cycle-countendpoints so the app keeps working after the backend cleanup in hotwax/hotwax-poorti#247.Closes #1397.
What changed
inventory-cycle-count/user/${partyId}/facilitiestoadmin/user/${partyId}/facilitiesinventory-cycle-count/productStores/${productStoreId}/settingstoadmin/productStores/${productStoreId}/settingsWhy
The backend PR removes deprecated resources for
user,productStores,facilities,enums, andloginfromservice/inventorycount.rest.xml. Inventory Count had already moved some surfaces toadmin/...andoms/..., but login facility resolution and store settings were still on the deprecated contract.Validation
inventory-cycle-count/user,inventory-cycle-count/users,inventory-cycle-count/facilities, orinventory-cycle-count/productStoresreferences remain undersrc/npm run lintpasses with pre-existing warnings insrc/views/Tabs.vuenpm run buildstill fails for unrelated existing Shopify App Bridge module resolution and TS typing errors insrc/services/utils.ts