Skip to content

[codex] migrate deprecated inventory endpoints#1398

Merged
ymaheshwari1 merged 1 commit intomainfrom
codex/migrate-deprecated-inventory-endpoints
May 7, 2026
Merged

[codex] migrate deprecated inventory endpoints#1398
ymaheshwari1 merged 1 commit intomainfrom
codex/migrate-deprecated-inventory-endpoints

Conversation

@dt2patel
Copy link
Copy Markdown
Contributor

@dt2patel dt2patel commented May 5, 2026

Business summary

This removes Inventory Count's remaining dependency on deprecated inventory-cycle-count endpoints so the app keeps working after the backend cleanup in hotwax/hotwax-poorti#247.

Closes #1397.

What changed

  • migrated non-admin facility lookup from inventory-cycle-count/user/${partyId}/facilities to admin/user/${partyId}/facilities
  • migrated force-scan and barcode settings read/write from inventory-cycle-count/productStores/${productStoreId}/settings to admin/productStores/${productStoreId}/settings
  • removed stale unused helpers that still referenced deprecated facility/product-store routes

Why

The backend PR removes deprecated resources for user, productStores, facilities, enums, and login from service/inventorycount.rest.xml. Inventory Count had already moved some surfaces to admin/... and oms/..., but login facility resolution and store settings were still on the deprecated contract.

Validation

  • verified no remaining deprecated inventory-cycle-count/user, inventory-cycle-count/users, inventory-cycle-count/facilities, or inventory-cycle-count/productStores references remain under src/
  • npm run lint passes with pre-existing warnings in src/views/Tabs.vue
  • npm run build still fails for unrelated existing Shopify App Bridge module resolution and TS typing errors in src/services/utils.ts

@dt2patel dt2patel requested a review from ymaheshwari1 May 5, 2026 13:33
@dt2patel dt2patel marked this pull request as ready for review May 5, 2026 13:34
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request migrates several API endpoints from the inventory-cycle-count prefix to the admin prefix and removes the unused loadStoresByFacility and loadUserFacilities actions. The review feedback recommends using encodeURIComponent for dynamic URL parameters to ensure robustness and notes a potential mismatch between partyId and userLoginId for the updated user facilities endpoint.

Comment thread src/adapter/index.ts
Comment thread src/stores/productStore.ts
Comment thread src/stores/productStore.ts
@ymaheshwari1 ymaheshwari1 merged commit ae2601d into main May 7, 2026
2 checks passed
@ymaheshwari1 ymaheshwari1 deleted the codex/migrate-deprecated-inventory-endpoints branch May 7, 2026 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate inventory-count off deprecated inventory-cycle-count endpoints

2 participants