Accxui cycle count#1389
Open
Banibrata-Manna wants to merge 16 commits intomainfrom
Open
Conversation
…nt/typescript-estree compatibility >=4.3.5 <5.4.0
… all build errors
…to composable, remove Pinia dependency, and consolidate auth API calls per accxui updates.
1 task
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request migrates the project from Vue CLI to Vite, updates environment variable prefixes from VUE_APP_ to VITE_, and refactors authentication and API handling by introducing a shared @common module. Additionally, it includes a critical fix for a typo in the login endpoint URL and removes a debugging console log statement in the Login view.
| async function loginWithCredentials(username: string, password: string) { | ||
| try { | ||
| const resp = await api({ | ||
| url: "amdin/login", |
Contributor
There was a problem hiding this comment.
There is a typo in the login URL. amdin/login should be admin/login.
Suggested change
| url: "amdin/login", | |
| url: "admin/login", |
| const basicLogin = async () => { | ||
| try { | ||
| const { oms, token, expirationTime, omsRedirectionUrl } = route.query as any; | ||
| console.log("is this empty", omsRedirectionUrl) |
Contributor
There was a problem hiding this comment.
This console.log statement appears to be for debugging and should be removed from production code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short Description and Why It's Useful
This PR introduces changes regarding accxui migration of Cycle Count PWA.