Skip to content

Remove DBIC filter from facility country selection - #415

Draft
dt2patel wants to merge 2 commits into
mainfrom
codex/remove-dbic-country-filter
Draft

dt2patel wants to merge 2 commits into
mainfrom
codex/remove-dbic-country-filter

Conversation

@dt2patel

@dt2patel dt2patel commented Jun 10, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • remove the DBIC geo-group filter from facility country loading
  • open the existing address/contact modal immediately after creating a facility
  • route directly to facility configuration after the address modal closes
  • clean up router references that blocked the production build

Verification

  • npm run build

Closes #416

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces several updates to the facility creation and configuration flows. Key changes include adding optional chaining in FacilityAddressModal.vue to prevent null pointer exceptions, updating the utility actions to query Geo entities instead of GeoAssocAndGeoFrom, and refactoring the router/route references to use the setup context in AddFacilityConfig.vue and CreateFacility.vue. Additionally, the facility creation flow in CreateFacility.vue has been updated to sequentially create a default location, open the address modal, and redirect to the configuration page. Feedback is provided regarding error handling during these post-creation steps: if creating the default location or opening the address modal fails, the outer try-catch block will trigger a misleading failure message despite the facility being successfully created. It is recommended to wrap these subsequent operations in individual try-catch blocks to ensure robust navigation.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread src/views/CreateFacility.vue

@patelanil patelanil left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Log message format review

I reviewed the log/error messages added in this PR against our best practice: log-messages.md.

These added messages do not follow the [Entity] [Context] - [Action/Outcome/Issue] pattern:

  1. Failed to create default facility location
    Suggest: Facility - Failed to create default location
  2. Failed to open address modal
    Suggest: Facility - Failed to open address modal

Dynamic IDs belong in the [Context] block and the action text should stay constant, so messages group and count cleanly in Grafana/Loki during log analysis. Please align these before merge.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Track PR #415: Remove DBIC filter from facility country selection

2 participants