Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces several updates to the facility creation and configuration flows. Key changes include adding optional chaining in FacilityAddressModal.vue to prevent null pointer exceptions, updating the utility actions to query Geo entities instead of GeoAssocAndGeoFrom, and refactoring the router/route references to use the setup context in AddFacilityConfig.vue and CreateFacility.vue. Additionally, the facility creation flow in CreateFacility.vue has been updated to sequentially create a default location, open the address modal, and redirect to the configuration page. Feedback is provided regarding error handling during these post-creation steps: if creating the default location or opening the address modal fails, the outer try-catch block will trigger a misleading failure message despite the facility being successfully created. It is recommended to wrap these subsequent operations in individual try-catch blocks to ensure robust navigation.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
patelanil
left a comment
There was a problem hiding this comment.
Log message format review
I reviewed the log/error messages added in this PR against our best practice: log-messages.md.
These added messages do not follow the [Entity] [Context] - [Action/Outcome/Issue] pattern:
Failed to create default facility location
Suggest:Facility - Failed to create default locationFailed to open address modal
Suggest:Facility - Failed to open address modal
Dynamic IDs belong in the [Context] block and the action text should stay constant, so messages group and count cleanly in Grafana/Loki during log analysis. Please align these before merge.
Summary
Verification
Closes #416