Removed the hardcoded check from the useNativeFulfillment toggle

[G0V1NDK]

closes: #365

[gemini-code-assist]

Summary of Changes

Hello @G0V1NDK, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue where the createLoginCreds function was being incorrectly assigned a boolean value instead of being called as a method when the 'Uses native fulfillment app' toggle changed. The fix ensures the proper execution of the createLoginCreds method, enhancing the functionality and correctness of the facility configuration view.

Highlights

• Frontend Logic Correction: Corrected the ionChange event handler for the 'Uses native fulfillment app' toggle in src/views/AddFacilityConfig.vue. The handler was changed from createLoginCreds = true to createLoginCreds, ensuring the createLoginCreds method is invoked as intended, rather than being assigned a boolean value.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request aims to remove a hardcoded value in the useNativeFulfillment toggle. However, the current change introduces a bug by incorrectly binding a data property to an event handler that expects a method or an inline expression. I've provided a critical review comment with a suggested fix that not only corrects the issue but also improves the logic by properly linking the two related toggles, which also resolves a pre-existing bug.