Updates to error messages, canvas size calculation, documentation, examples#5
Open
patitsas wants to merge 32 commits intohotdogee:masterfrom
Open
Updates to error messages, canvas size calculation, documentation, examples#5patitsas wants to merge 32 commits intohotdogee:masterfrom
patitsas wants to merge 32 commits intohotdogee:masterfrom
Conversation
what to do if sun radius is 0
Creating an error message for if the program is unable to calculate the sun's radius from an input file.
…n-annular-eclipse/?p=13012539 Handles issue of negative values from hotdogee#3
Also adding a note for what to do if requirements break
Also adjusting the canvas size code, the fix from the forum post doesn't always work.
making a directory for example2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added two new error messages: if the sun radius was not calculated, and if the sun radius is less than 50 pixels. This will handle Issue #4 . I also tweaked wording for fix_angle because it had confused me.
I updated the canvas size calculation to fix Issue #3 .
The link to example files on the README is broken, so I made three example sets for people to confirm the code is indeed working for them.
I updated README to reflect the addition of example cases. I removed the broken link. I also address the unstated assumption that sun radius is >50 pixels, gave guidance for if the code fails to compute a sun radius, and guidance for if the pip requirements step breaks.