fix(hosts): the node-side resolve switch is super_admin only - #23
Merged
Merged
Conversation
The switch waives panel-side resolution, and with it the screen that checks where a backend actually points. It was settable by any account that could edit a route, so a scope-restricted admin could turn off screening for their own route. Same bar as skipping upstream TLS verification now. The policy lives in one function rather than two literal role comparisons, so the create and edit forms cannot drift apart.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Authorization gap found by an independent review of 1.7.0. Impact and scope are in the CHANGELOG.
Verified:
go build,go vet,make check-migrations, all five Compose profiles,go test -race ./...(41 packages).