Move commands and colours out of the driver.#4
Open
hosaka wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discussed on the micropython forums:
const()variables still allocate memory when used. Until there is some enhancement in place to help save memory when using consts, I moved the register/commands definitions out of the driver into the TFT module and commented out those that are not in use.Few references to commands in the driver itself, were replaced with a hardcoded value and a small comment, so shouldn't hinder readability.
I am also planning on having the same done for init functions of the TFT/TFT_GREEN and colours, perhaps having them in the separate file could be a good interim step.