fix: enforce validation for empty custom_headers in webhook configurations#674
Open
alexbouchardd wants to merge 1 commit intomainfrom
Open
fix: enforce validation for empty custom_headers in webhook configurations#674alexbouchardd wants to merge 1 commit intomainfrom
alexbouchardd wants to merge 1 commit intomainfrom
Conversation
Contributor
alexbouchardd
commented
Feb 4, 2026
alexbouchardd
commented
- Updated tests to ensure that an error is returned when custom_headers is empty or invalid.
- Modified the WebhookDestination and StandardWebhookDestination to return validation errors for empty custom_headers.
- Adjusted frontend logic to handle empty custom_headers appropriately, ensuring backward compatibility while enforcing validation rules.
…tions - Updated tests to ensure that an error is returned when custom_headers is empty or invalid. - Modified the WebhookDestination and StandardWebhookDestination to return validation errors for empty custom_headers. - Adjusted frontend logic to handle empty custom_headers appropriately, ensuring backward compatibility while enforcing validation rules.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
alexluong
reviewed
Feb 5, 2026
| var validationErr *destregistry.ErrDestinationValidation | ||
| assert.ErrorAs(t, err, &validationErr) | ||
| assert.Equal(t, "config.custom_headers", validationErr.Errors[0].Field) | ||
| assert.Equal(t, "required", validationErr.Errors[0].Type) |
Collaborator
There was a problem hiding this comment.
hey the test suite is failing because the assertion here is incorrect. Based on the error you're throwing, it should be "invalid" instead of "required"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.