Skip to content

fix: portal attempt query params #673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alexluong wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: portal attempt query params #673

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4783973
chore: list attempt query comment
alexluong Feb 3, 2026
0cf56d7
fix: portal attempt query params
alexluong Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions internal/apirouter/log_handlers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ func toAPIAttempt(ar *logstore.AttemptRecord, opts IncludeOptions) APIAttempt {
}

// ListAttempts handles GET /attempts
// Query params: tenant_id, event_id, destination_id, status, topic[], start, end, limit, next, prev, expand[], sort_order
// Query params: tenant_id, event_id, destination_id, status, topic[], time[gte], time[lte], time[gt], time[lt], limit, next, prev, include, order_by, dir
func (h *LogHandlers) ListAttempts(c *gin.Context) {
// Authz: JWT users can only query their own tenant's attempts
tenantID, ok := resolveTenantIDFilter(c)
Expand Down Expand Up @@ -359,7 +359,7 @@ func (h *LogHandlers) RetrieveAttempt(c *gin.Context) {
}

// ListEvents handles GET /events
// Query params: tenant_id, destination_id, topic[], start, end, limit, next, prev, sort_order
// Query params: tenant_id, destination_id, topic[], time[gte], time[lte], time[gt], time[lt], limit, next, prev, include, order_by, dir
func (h *LogHandlers) ListEvents(c *gin.Context) {
// Authz: JWT users can only query their own tenant's events
tenantID, ok := resolveTenantIDFilter(c)
Expand Down
6 changes: 3 additions & 3 deletions internal/portal/src/scenes/Destination/Events/Attempts.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,19 +46,19 @@ const Attempts: React.FC<AttemptsProps> = ({
switch (timeRange) {
case "7d":
searchParams.set(
"start",
"time[gte]",
new Date(now.getTime() - 7 * 24 * 60 * 60 * 1000).toISOString(),
);
break;
case "30d":
searchParams.set(
"start",
"time[gte]",
new Date(now.getTime() - 30 * 24 * 60 * 60 * 1000).toISOString(),
);
break;
default: // 24h
searchParams.set(
"start",
"time[gte]",
new Date(now.getTime() - 24 * 60 * 60 * 1000).toISOString(),
);
}
Expand Down
Loading