fix: correct Windows 32-bit compiler and error handling in npm build#201
Closed
Copilot wants to merge 2 commits intofeat/install-processfrom
Closed
fix: correct Windows 32-bit compiler and error handling in npm build#201Copilot wants to merge 2 commits intofeat/install-processfrom
Copilot wants to merge 2 commits intofeat/install-processfrom
Conversation
7 tasks
…error handling, and CGO settings Co-authored-by: leggetter <328367+leggetter@users.noreply.github.com>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Fix pnpm v10+ compatibility with GoReleaser
fix: correct Windows 32-bit compiler and error handling in npm build
Feb 3, 2026
Collaborator
Contributor
Author
|
Yes, commit 7002310 addresses my feedback and takes an even better approach. Instead of fixing the Windows 32-bit compiler (which I suggested), it disables CGO entirely for all platforms since the codebase has no C dependencies. This is cleaner - it eliminates the need for mingw cross-compilers completely and simplifies the build process. The commit addresses all my review points:
The pure Go approach ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code review identified critical build configuration errors that would prevent Windows 32-bit binaries from building and cause incorrect exit codes when binaries are missing.
Changes
i686-w64-mingw32-gccinstead ofx86_64-w64-mingw32-gccfor 386 architecture||with??operator in wrapper script to handlenullstatus correctlygcc-mingw-w64-i686package to both release and test workflowsBefore
After
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.