fix: Use TLS dial for HTTPS healthchecks to prevent handshake warnings#199
Merged
fix: Use TLS dial for HTTPS healthchecks to prevent handshake warnings#199
Conversation
The healthcheck functionality was using raw TCP connections which caused TLS handshake warnings on HTTPS servers with self-signed certificates. Changes: - Use tls.DialWithDialer for HTTPS endpoints with InsecureSkipVerify respecting the --insecure flag - Add --no-healthcheck flag to disable health monitoring entirely - Update tests for HTTPS healthcheck scenarios - Update documentation for both flags Fixes #198 Co-authored-by: Cursor <cursoragent@cursor.com>
Collaborator
Author
|
@copilot can you review? |
Contributor
|
@leggetter I've opened a new pull request, #200, to work on those changes. Once the pull request is ready, I'll request review from you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--no-healthcheckflag as an escape hatch to disable health monitoring entirelyChanges
tls.DialWithDialerfor HTTPS endpoints withInsecureSkipVerifyrespecting the--insecureflag--no-healthcheckflag to disable periodic health checksTest plan
go test ./pkg/...)--no-healthcheckflag appears inhookdeck listen --helpFixes #198
Made with Cursor