-
Notifications
You must be signed in to change notification settings - Fork 277
feat(oauth-providers): Allow for refresh tokens to be used via access_type "offline" in Issue/#619 #634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
I also don't really understand why it had my other pull requests in the commit logs... No changes for those files are actually in this pull request |
|
Closes #619 |
|
Hi @aaronware Thanks for the PR. I think it would be fine if you tested it with the @monoald Do you have any thoughts on this? |
|
Hi! We are also interested in this behaviour to configure long-running sessions (eg. polling GMail on behalf of a user). Right now the flow does not expose the refresh token (although it is received), but could very easily when correctly configured with prompt: "consent" and access_type: "offline". It is hard to monkey patch at this time as this is internal to AuthFlow. I don't know if this PR is still under consideration or if I should open a new one to cover this use case. |
|
Hi @Titou325 This PR is not progressing, so creating a new PR is okay. If so, I will review it. It would be better if you added proper tests there. |
|
agreed, it'd be nice if we had support for google refresh tokens |
|
Hi @aaronware Can you still work on this PR? I think this feature is okay, but I want to do two things:
If these are done, I'll review them! |
|
@yusukebe I can pick this up again in the next week or so |
🦋 Changeset detectedLatest commit: 4c89a8c The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Hi! I'm I would like to apply some automated changes to this pull request, but it looks like I don't have the necessary permissions to do so. To get this pull request into a mergeable state, please do one of the following two things:
|
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (25.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #634 +/- ##
==========================================
- Coverage 83.41% 82.29% -1.12%
==========================================
Files 102 103 +1
Lines 3352 3401 +49
Branches 867 883 +16
==========================================
+ Hits 2796 2799 +3
- Misses 466 500 +34
- Partials 90 102 +12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
I might need some support here as I wasn't able to figure out the most efficient way to test my changes based on how this all works within a worker? Any shove in the right direction would be greatly appreciated for proper testing.