Repository navigation
Preserve literal code in generic provider prompt templates - #8
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generic HTTP templates such as
prefix ${PROMPT}could replace${MAX_TOKENS}or${TEMPERATURE}inside the inserted source prompt a second time, changing literal code before sending it to the provider.Expand the template in one pass, preserving all inserted prompt text. Whole-value numeric placeholders keep their original JSON number types. Add a real HTTP regression and document the behavior.
Validation: the new regression was observed failing before the fix; all 63 provider tests pass after it. The rebuilt non-editable wheel full suite passed: 198 passed, 5 explicit local Docker skips, zero failures/errors. All 9 CI jobs passed: https://github.com/hongzuoj-pixel/MiMo-CodeHarness/actions/runs/39032808715. Linux full suite: 198 passed/5 Docker skips; Windows: 193 passed/10 explicit platform skips; real Docker: 5 passed. Tree: a72c8bd4c684d05a5155d27ad2a92faf977bde6f. This is a focused follow-up to #7; it does not enable paid calls or alter existing verification/acceptance policy.
Post-merge validation: https://github.com/hongzuoj-pixel/MiMo-CodeHarness/actions/runs/39033049583 — all 9 jobs passed on main commit 2126f69. Merged tree a72c8bd4c684d05a5155d27ad2a92faf977bde6f exactly matches the installed-wheel/tested tree. Local main is fast-forwarded and clean. Full local installed suite: 198 passed, 5 explicit Docker skips; the separate real Docker job passes all 5 tests.