Skip to content

Revert "Add USBIP config D-Bus interface"#267

Open
agners wants to merge 1 commit into
mainfrom
revert-265-add-usbip-config
Open

Revert "Add USBIP config D-Bus interface"#267
agners wants to merge 1 commit into
mainfrom
revert-265-add-usbip-config

Conversation

@agners

@agners agners commented Jun 17, 2026

Copy link
Copy Markdown
Member

It seems we can archive the same by using transient systemd units with customized arguments.

Reverts #265

Summary by CodeRabbit

  • Chores
    • Removed USBIP remote device configuration management.

@coderabbitai

coderabbitai Bot commented Jun 17, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: a5089592-cd49-4b97-ac83-9c9afd4dfde8

📥 Commits

Reviewing files that changed from the base of the PR and between f5a49d3 and 5c1ea45.

📒 Files selected for processing (3)
  • config/usbip/usbip.go
  • config/usbip/usbip_test.go
  • main.go
💤 Files with no reviewable changes (3)
  • config/usbip/usbip.go
  • main.go
  • config/usbip/usbip_test.go

📝 Walkthrough

Walkthrough

The PR deletes the entire USBIP DBus service: config/usbip/usbip.go (203 lines) containing identifier validation, config file path derivation, systemd EnvironmentFile rendering, and remote-device CRUD operations; config/usbip/usbip_test.go (148 lines) covering all those operations; and the corresponding import and usbip.InitializeDBus(conn) call in main.go.

Changes

USBIP DBus service removal

Layer / File(s) Summary
Remove usbip import and DBus initialization
main.go
Removes the config/usbip import and the usbip.InitializeDBus(conn) call; the rest of the DBus initialization sequence is unchanged.
Delete USBIP service implementation and tests
config/usbip/usbip.go, config/usbip/usbip_test.go
Removes the complete USBIP DBus service (identifier validation, config path derivation, systemd EnvironmentFile rendering, WriteRemoteDevice, RemoveRemoteDevice, ListRemoteDevices, InitializeDBus) and all associated unit tests.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title accurately describes the main change: reverting the USBIP config D-Bus interface addition. It directly corresponds to the changeset which removes the usbip module implementation, tests, and initialization calls.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch revert-265-add-usbip-config

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants