Proxmox dynamic storage#59
Draft
abb848 wants to merge 7 commits into
Draft
Conversation
![home-assistant[bot]](https://avatars.githubusercontent.com/in/97978?s=60&v=4){kind=small}
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #59 +/- ##
==========================================
- Coverage 89.54% 89.40% -0.14%
==========================================
Files 29 29
Lines 10910 10939 +29
Branches 84 84
==========================================
+ Hits 9769 9780 +11
- Misses 1141 1159 +18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
home-assistant
Bot
added
cla-recheck
cla-signed
and removed
cla-recheck
cla-needed
labels
There was a problem hiding this comment.
Pull request overview
Adds dynamic Proxmox import-storage selection instead of hardcoding local.
Changes:
- Selects storage supporting the
importcontent type. - Propagates its name through upload and VM creation.
- Adds a clearer error when no suitable storage exists.
| pub async fn get_storage_name(session: &ProxmoxSession, node: &str) -> Result<String> { | ||
| let storage_list = list_storage(&session, node).await?; | ||
| for storage in storage_list { | ||
| if storage.content.contains(&"import".to_string()) { |
Comment on lines
+1009
to
+1010
| //Get the proxmox storage name for install before downloading the image and wasting bandwidth | ||
| let storage_name = get_storage_name(session, &config.node).await?; |
| node: &str, | ||
| local_path: &std::path::PathBuf, | ||
| progress_callback: &P, | ||
| storage_name: &str, |
| } | ||
|
|
||
| /// Get the name of available storage on a node | ||
| pub async fn get_storage_name(session: &ProxmoxSession, node: &str) -> Result<String> { |
Member
Author
There was a problem hiding this comment.
These tests already used local before my change, I just added the parameter to keep the same behavior. I haven't addressed the tests, so simply kept the same hardcoded string for them.
| }; | ||
|
|
||
| let result = create_vm_with_disk(&session, &config, "test-image.qcow2").await; | ||
| let result = create_vm_with_disk(&session, &config, "test-image.qcow2", "local").await; |
Member
Author
There was a problem hiding this comment.
This is part of testing, see comment above
Comment on lines
+3102
to
+3103
| let result = | ||
| upload_image_to_proxmox(&session, "pve", &temp_file, &callback, "local").await; |
Member
Author
There was a problem hiding this comment.
This is part of testing, see comment above
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
| pub async fn get_storage_name(session: &ProxmoxSession, node: &str) -> Result<String> { | ||
| let storage_list = list_storage(session, node).await?; | ||
| for storage in storage_list { | ||
| if storage.active && storage.content.iter().any(|content| content == "import") { |
Comment on lines
+402
to
+405
| pub async fn get_storage_name(session: &ProxmoxSession, node: &str) -> Result<String> { | ||
| let storage_list = list_storage(session, node).await?; | ||
| for storage in storage_list { | ||
| if storage.active && storage.content.iter().any(|content| content == "import") { |
| //! 1. Download the qcow2.xz image locally | ||
| //! 2. Extract to qcow2 | ||
| //! 3. Upload qcow2 to Proxmox "local" storage (content=import) | ||
| //! 3. Upload qcow2 to Proxmox storage (content=import). storage is checked for import flag and set dynamically |
| node: &str, | ||
| local_path: &std::path::PathBuf, | ||
| progress_callback: &P, | ||
| storage_name: &str, |
| pub async fn get_storage_name(session: &ProxmoxSession, node: &str) -> Result<String> { | ||
| let storage_list = list_storage(session, node).await?; | ||
| for storage in storage_list { | ||
| if storage.active && storage.content.iter().any(|content| content == "import") { |
Member
Author
There was a problem hiding this comment.
ESXi storage is very unlikely for this use case but this could be considered if needed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Proxmox part of the installer hardcoded the upload storage name as
local. It also doesn't check to see if the storage hasimportenabled.This change adds a
get_storage_namefunction to query available storage, and find the first one withimportenabled. The storage name is then passed across the process. This step also runs before the installer is downloaded, meaning that the user doesn't have to wait for the download to complete, only for it to error (like it did for me a few times). I've also added error handling in the event Proxmox has no storage withimportenabled (which is the case for a default install), to give a different error message for clarity that it's something the user has to action currently.Type of Change
Related Issues
Closes #56
Testing
Tested end to end via windows on the Proxmox 9.2.4
Screenshots
New error message UI
Checklist
cargo fmtandnpm run lintdevices.rs)