Create workflow to sign mac app + replace bundle ID#52
Draft
bgoncal wants to merge 4 commits into
Draft
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #52 +/- ##
=======================================
Coverage 89.54% 89.54%
=======================================
Files 29 29
Lines 10910 10910
Branches 84 84
=======================================
Hits 9769 9769
Misses 1141 1141
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Adds a manually-triggered GitHub Actions workflow to build, sign, notarize, and publish a macOS DMG for the Tauri-based Home Assistant Installer, and updates the app’s bundle identifier in the Tauri config to match the new App Store Connect setup.
Changes:
- Changed the Tauri
identifier(bundle ID) used for macOS packaging/signing. - Added a
release-mac.ymlworkflow that imports a Developer ID cert into an ephemeral keychain, builds a universal macOS bundle, notarizes/staples the DMG, verifies, and uploads the DMG as an artifact.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
crates/hai-desktop/tauri.conf.json |
Updates the bundle identifier used by Tauri for the macOS app bundle. |
.github/workflows/release-mac.yml |
Introduces a macOS release workflow for signing + notarization + DMG artifact upload. |
Comment on lines
+85
to
+88
| APP=$(find target/universal-apple-darwin/release/bundle/macos -maxdepth 1 -name "*.app" | head -1) | ||
| DMG=$(find target/universal-apple-darwin/release/bundle/dmg -maxdepth 1 -name "*.dmg" | head -1) | ||
| echo "App: $APP" | ||
| echo "DMG: $DMG" |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Comment on lines
+9
to
+13
| release-macos: | ||
| name: Release macOS (signed + notarized) | ||
| runs-on: macos-latest | ||
| permissions: | ||
| contents: read |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Comment on lines
+9
to
+13
| release-macos: | ||
| name: Release macOS (signed + notarized) | ||
| runs-on: macos-latest | ||
| permissions: | ||
| contents: read |
Comment on lines
+9
to
+13
| release-macos: | ||
| name: Release macOS (signed + notarized) | ||
| runs-on: macos-latest | ||
| permissions: | ||
| contents: read |
| KEYCHAIN_PATH="$RUNNER_TEMP/app-signing.keychain-db" | ||
| CERT_PATH="$RUNNER_TEMP/certificate.p12" | ||
|
|
||
| echo "$APPLE_CERTIFICATE" | base64 --decode > "$CERT_PATH" |
| env: | ||
| APPLE_API_KEY_P8: ${{ secrets.APPLE_API_KEY_P8 }} | ||
| run: | | ||
| echo "$APPLE_API_KEY_P8" | base64 --decode > "$RUNNER_TEMP/AuthKey.p8" |
bgoncal
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add workflow to sign and notarize the mac app, the secrets below still need to be added
Type of Change
Related Issues
Testing
Screenshots
Checklist
cargo fmtandnpm run lint