Add support of multiple Tado accounts - #31527
Merged
Merged
Conversation
Changed geberation of sensor unique id (breaking change)
|
Hey there @michaelarnauts, mind taking a look at this pull request as its been labeled with a integration ( |
7 tasks
Codecov Report
@@ Coverage Diff @@
## dev #31527 +/- ##
==========================================
+ Coverage 94.58% 94.66% +0.07%
==========================================
Files 746 762 +16
Lines 54025 55017 +992
==========================================
+ Hits 51101 52081 +980
- Misses 2924 2936 +12
Continue to review full report at Codecov.
|
Member
|
Please don't merge to |
7 tasks
Member
|
Why not migrate to config entries ? |
gorynychzmey
marked this pull request as ready for review
February 6, 2020 17:45
balloob
reviewed
Feb 10, 2020
balloob
reviewed
Feb 10, 2020
balloob
approved these changes
Feb 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support of multiple Tado accounts
Changed generation of sensor unique id.
FIxed error detecting opened window.
Breaking change
Changed generation of unique id of sensor and climate - now it includes id of home.
Proposed change
RIght now Tado has no native support of multiple bridges in one account. This change allows to add multiple Tado accounts to HASS.
Type of change
Example entry for
configuration.yaml:In case of only one account this configuration will also work:
Additional information
Important: chrism0dwk/PyTado#10 must be merged into PyTado to this change to work correctly.
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: