Add zone conditions in / not in zone#172810
Open
emontnemery wants to merge 1 commit into
Open
Conversation
Contributor
|
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds new-style Zone conditions to the zone integration to allow automations to check whether one or more person / device_tracker entities are in (or not in) a selected zone, including support for behavior and for.
Changes:
- Add
zone.in_zoneandzone.not_in_zoneentity-target conditions backed byEntityConditionBase. - Add condition descriptions and icons (
conditions.yaml,strings.json,icons.json) for the new conditions. - Add a new test suite covering validation and any/all behavior for the new conditions.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
homeassistant/components/zone/condition.py |
Adds InZoneCondition / NotInZoneCondition and registers them in async_get_conditions. |
homeassistant/components/zone/conditions.yaml |
Declares UI/description schema for the new conditions, including behavior, for, and zone. |
homeassistant/components/zone/strings.json |
Adds localized strings for the new condition names/descriptions and shared field labels. |
homeassistant/components/zone/icons.json |
Adds icons for the new conditions. |
tests/components/zone/test_condition.py |
Adds validation and behavior tests for zone.in_zone and zone.not_in_zone. |
Comment on lines
+158
to
+161
| _DOMAIN_SPECS: dict[str, DomainSpec] = { | ||
| "person": DomainSpec(), | ||
| "device_tracker": DomainSpec(), | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Add zone conditions in / not in zone
Type of change
Additional information
zone.in_zonecondition #168375zone.not_in_zonecondition #168376Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: