Skip to content

Bump aioaquarite to 0.5.1#172754

Open
fdebrus wants to merge 1 commit into
home-assistant:devfrom
fdebrus:vistapool-aioaquarite-0.5.1
Open

Bump aioaquarite to 0.5.1#172754
fdebrus wants to merge 1 commit into
home-assistant:devfrom
fdebrus:vistapool-aioaquarite-0.5.1

Conversation

@fdebrus
Copy link
Copy Markdown
Contributor

@fdebrus fdebrus commented Jun 1, 2026

Breaking change

Proposed change

Bumps aioaquarite from 0.4.0 to 0.5.1.

0.5.1 wraps aiohttp.ClientError and asyncio.TimeoutError from both the REST send_command path and the upstream _auth.get_client() refresh in ConnectionError (an AquariteError subclass), so transport failures surface as the library's documented domain error rather than leaking aiohttp internals to callers.

This lets the Vistapool integration's entity actions (already merged sensor, plus the open binary_sensor / switch / light / select / number / button PRs) translate every write failure to the existing set_failed HomeAssistantError via their except AquariteError clauses, instead of leaking aiohttp exceptions as generic service-call failures.

Split out from the platform PRs per @joostlek's request so the bump can be reviewed and merged independently.

Library changelog

  • 0.5.1 — Wrap aiohttp.ClientError and asyncio.TimeoutError from send_command and _auth.get_client() in ConnectionError (an AquariteError subclass). No public-API change.
  • 0.5.0 — [previous release notes]

Diff: fdebrus/aioaquarite@v0.4.0...v0.5.1

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue: Vistapool platform PRs (binary_sensor Add number platform to Vistapool #172542, switch TBD, light TBD, select TBD, number TBD, button TBD)
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

0.5.1 wraps aiohttp.ClientError and asyncio.TimeoutError from both the
REST send_command path and the upstream auth client refresh in
ConnectionError (an AquariteError subclass), so transport failures
surface as the library's documented domain error rather than leaking
aiohttp internals to callers.
Copilot AI review requested due to automatic review settings June 1, 2026 15:23
@home-assistant home-assistant Bot added dependency Pull requests marked as a dependency upgrade integration: vistapool small-pr PRs with less than 30 lines. by-code-owner Quality Scale: bronze labels Jun 1, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Updates the VistaPool integration to use a newer aioaquarite dependency version.

Changes:

  • Bump aioaquarite from 0.4.0 to 0.5.1 in the integration manifest.
  • Align global requirements_all.txt pin for aioaquarite to 0.5.1.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
requirements_all.txt Updates the global pinned version of aioaquarite to match the integration requirement.
homeassistant/components/vistapool/manifest.json Updates the integration dependency pin to aioaquarite==0.5.1.

@fdebrus fdebrus mentioned this pull request Jun 1, 2026
21 tasks
@fdebrus fdebrus marked this pull request as ready for review June 1, 2026 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

by-code-owner dependency Pull requests marked as a dependency upgrade integration: vistapool Quality Scale: bronze small-pr PRs with less than 30 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants