Bump aioaquarite to 0.5.1#172754
Open
fdebrus wants to merge 1 commit into
Open
Conversation
0.5.1 wraps aiohttp.ClientError and asyncio.TimeoutError from both the REST send_command path and the upstream auth client refresh in ConnectionError (an AquariteError subclass), so transport failures surface as the library's documented domain error rather than leaking aiohttp internals to callers.
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the VistaPool integration to use a newer aioaquarite dependency version.
Changes:
- Bump
aioaquaritefrom0.4.0to0.5.1in the integration manifest. - Align global
requirements_all.txtpin foraioaquariteto0.5.1.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| requirements_all.txt | Updates the global pinned version of aioaquarite to match the integration requirement. |
| homeassistant/components/vistapool/manifest.json | Updates the integration dependency pin to aioaquarite==0.5.1. |
21 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Bumps
aioaquaritefrom 0.4.0 to 0.5.1.0.5.1 wraps
aiohttp.ClientErrorandasyncio.TimeoutErrorfrom both the RESTsend_commandpath and the upstream_auth.get_client()refresh inConnectionError(anAquariteErrorsubclass), so transport failures surface as the library's documented domain error rather than leaking aiohttp internals to callers.This lets the Vistapool integration's entity actions (already merged
sensor, plus the openbinary_sensor/switch/light/select/number/buttonPRs) translate every write failure to the existingset_failedHomeAssistantErrorvia theirexcept AquariteErrorclauses, instead of leakingaiohttpexceptions as generic service-call failures.Split out from the platform PRs per @joostlek's request so the bump can be reviewed and merged independently.
Library changelog
aiohttp.ClientErrorandasyncio.TimeoutErrorfromsend_commandand_auth.get_client()inConnectionError(anAquariteErrorsubclass). No public-API change.Diff: fdebrus/aioaquarite@v0.4.0...v0.5.1
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: