Make media_player platform a labs feature for Alexa Devices by jamesonuk · Pull Request #170890 · home-assistant/core

jamesonuk · 2026-05-16T11:50:42Z

Proposed change

Make Media Player platform to be introduced in #165825 a labs feature.
This is to allow us to gather feedback on how well this implementation works across a wider audience and more devices.

Type of change

Dependency upgrade
Bugfix (non-breaking change which fixes an issue)
New integration (thank you!)
New feature (which adds functionality to an existing integration)
Deprecation (breaking change to happen in the future)
Breaking change (fix/feature causing existing functionality to break)
Code quality improvements to existing code or addition of tests

Additional information

This PR fixes or closes issue: fixes #
This PR is related to issue:
Link to documentation pull request: Add Media Player documentation for Alexa Devices home-assistant.io#45262
Link to developer documentation pull request:
Link to frontend pull request:

Checklist

I understand the code I am submitting and can explain how it works.
The code change is tested and works locally.
Local tests pass. Your PR cannot be merged unless tests pass
There is no commented out code in this PR.
I have followed the development checklist
I have followed the perfect PR recommendations
The code has been formatted using Ruff (ruff format homeassistant tests)
Tests have been added to verify that the new code works.
Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

The manifest file has all fields filled out correctly.
Updated and included derived files by running: python3 -m script.hassfest.
New or updated dependencies have been added to requirements_all.txt.
Updated by running python3 -m script.gen_requirements_all.
For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

I have reviewed two other open pull requests in this repository.

home-assistant · 2026-05-16T11:50:50Z

Hey there @chemelli74, mind taking a look at this pull request as it has been labeled with an integration (alexa_devices) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of alexa_devices can trigger bot actions by commenting:

@home-assistant close Closes the pull request.
@home-assistant mark-draft Mark the pull request as draft.
@home-assistant ready-for-review Remove the draft status from the pull request.
@home-assistant rename Awesome new title Renames the pull request.
@home-assistant reopen Reopen the pull request.
@home-assistant unassign alexa_devices Removes the current integration label and assignees on the pull request, add the integration domain after the command.
@home-assistant update-branch Update the pull request branch with the base branch.
@home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) to the pull request.
@home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) on the pull request.

Copilot

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds an Alexa Devices media player platform behind a Labs preview feature, backed by HTTP/2 push updates, and introduces coordinator support/tests for pushed media/volume state.

Changes:

Introduces media_player platform for Alexa Devices with dynamic supported features and service→API mappings.
Adds coordinator plumbing for pushed media/volume state plus a sync_media_state() API wrapper with config-entry exceptions.
Adds Labs preview feature metadata/strings and extensive test coverage (snapshots + platform/coordinator/init tests).

Reviewed changes

Copilot reviewed 10 out of 11 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
`homeassistant/components/alexa_devices/__init__.py`	Gates media player behind Labs, starts/cancels HTTP/2 processing, and forwards/unloads platform dynamically.
`homeassistant/components/alexa_devices/coordinator.py`	Stores pushed media/volume state, wires signal handlers, and adds `sync_media_state()` error mapping.
`homeassistant/components/alexa_devices/media_player.py`	New MediaPlayer entity implementation using coordinator state and API calls.
`homeassistant/components/alexa_devices/manifest.json`	Declares the `alexa_media` preview feature metadata.
`homeassistant/components/alexa_devices/strings.json`	Adds preview feature UI strings and an `invalid_auth` error string.
`homeassistant/generated/labs.py`	Registers Labs metadata for the new preview feature.
`tests/components/alexa_devices/conftest.py`	Extends client fixture with signals + HTTP/2 processing mocks.
`tests/components/alexa_devices/test_init.py`	Adds tests for reauth callback wiring and HTTP/2 task cancellation on unload.
`tests/components/alexa_devices/test_coordinator.py`	Adds tests for push-event handling and `sync_media_state()` error mapping.
`tests/components/alexa_devices/test_media_player.py`	Adds comprehensive media player behavior and service-call tests + snapshots.
`tests/components/alexa_devices/snapshots/test_media_player.ambr`	Snapshot baseline for entity registry + initial state.

Copilot

Pull request overview

Copilot reviewed 10 out of 11 changed files in this pull request and generated 6 comments.

Copilot

Pull request overview

Copilot reviewed 10 out of 11 changed files in this pull request and generated 4 comments.

Copilot

Pull request overview

Copilot reviewed 10 out of 11 changed files in this pull request and generated 5 comments.

Copilot

Pull request overview

Copilot reviewed 10 out of 11 changed files in this pull request and generated 5 comments.

Copilot

Pull request overview

Copilot reviewed 10 out of 11 changed files in this pull request and generated 3 comments.

Copilot

Pull request overview

Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.

chemelli74

Thx @jamesonuk

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot

Pull request overview

Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.

Copilot

Pull request overview

Copilot reviewed 5 out of 6 changed files in this pull request and generated 4 comments.

Copilot AI review requested due to automatic review settings May 16, 2026 11:50

home-assistant Bot added cla-signed has-tests integration: alexa_devices new-feature new-platform Top 200 Integration is ranked within the top 200 by usage labels May 16, 2026

home-assistant Bot assigned chemelli74 May 16, 2026

home-assistant Bot added the Quality Scale: platinum label May 16, 2026

Copilot AI reviewed May 16, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings May 16, 2026 12:09

Copilot AI reviewed May 16, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings May 16, 2026 13:06

Copilot AI reviewed May 16, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings May 16, 2026 17:01

Copilot AI reviewed May 16, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings May 20, 2026 12:03

Copilot AI reviewed May 20, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings May 20, 2026 14:47

jamesonuk marked this pull request as ready for review May 20, 2026 14:49

jamesonuk requested a review from chemelli74 as a code owner May 20, 2026 14:49

Copilot AI reviewed May 20, 2026

View reviewed changes

Comment thread homeassistant/components/alexa_devices/__init__.py Outdated

Comment thread homeassistant/components/alexa_devices/coordinator.py Outdated

Comment thread homeassistant/components/alexa_devices/media_player.py

chemelli74 changed the title ~~make media player platform labs feature in alexa devices~~ Make media_player platform a labs feature for Alexa Devices May 28, 2026

e4b1b1e

chemelli74 force-pushed the ad_media_player_labs branch from e7c3d04 to e4b1b1e Compare May 28, 2026 16:31

chemelli74 added this to the 2026.6.0 milestone May 28, 2026

remove http2 start/stop inside labs

8480b2c

Copilot AI review requested due to automatic review settings May 28, 2026 18:09

Copilot started reviewing on behalf of chemelli74 May 28, 2026 18:09 View session

Copilot AI reviewed May 28, 2026

View reviewed changes

Comment thread homeassistant/components/alexa_devices/__init__.py Outdated

Comment thread homeassistant/components/alexa_devices/__init__.py

chemelli74 added 2 commits May 28, 2026 18:49

apply review comments + tests

384f4f7

Merge branch 'dev' into ad_media_player_labs

8ebf582

Copilot AI review requested due to automatic review settings May 28, 2026 18:50

Copilot started reviewing on behalf of chemelli74 May 28, 2026 18:50 View session

chemelli74 approved these changes May 28, 2026

View reviewed changes

home-assistant Bot added the code-owner-approved label May 28, 2026

Copilot AI reviewed May 28, 2026

View reviewed changes

chemelli74 requested a review from Copilot May 28, 2026 18:54

Copilot started reviewing on behalf of chemelli74 May 28, 2026 18:54 View session

Copilot AI reviewed May 28, 2026

View reviewed changes

frenck requested a review from Copilot May 28, 2026 20:46

Copilot started reviewing on behalf of frenck May 28, 2026 20:46 View session

Copilot AI reviewed May 28, 2026

View reviewed changes

Comment thread homeassistant/components/alexa_devices/__init__.py Outdated

jamesonuk added 3 commits June 1, 2026 08:53

remove string added in error

3b9c7ed

ensure registry disabled when labs disabled

1d31cdf

Merge branch 'dev' into ad_media_player_labs

8038cd4

Copilot AI review requested due to automatic review settings June 1, 2026 10:37

Copilot AI reviewed Jun 1, 2026

View reviewed changes

Comment thread homeassistant/components/alexa_devices/__init__.py Outdated

Comment thread tests/components/alexa_devices/test_media_player.py

Comment thread tests/components/alexa_devices/test_init.py

Comment thread homeassistant/components/alexa_devices/strings.json Outdated

jamesonuk added 2 commits June 1, 2026 11:02

review comments

9a4094a

test coverage

4d01beb

Uh oh!

Conversation

jamesonuk commented May 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed change

Type of change

Additional information

Checklist

Uh oh!

home-assistant Bot commented May 16, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

chemelli74 left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

jamesonuk commented May 16, 2026 •

edited

Loading