Skip to content

Add bulk update action for todo lists#155922

Open
jamesmyatt wants to merge 33 commits into
home-assistant:devfrom
jamesmyatt:todo_reusable
Open

Add bulk update action for todo lists#155922
jamesmyatt wants to merge 33 commits into
home-assistant:devfrom
jamesmyatt:todo_reusable

Conversation

@jamesmyatt
Copy link
Copy Markdown

@jamesmyatt jamesmyatt commented Nov 6, 2025

Proposed change

Add "todo.update_list" service to mark all items as completed or not completed.

This makes todo lists reusable, e.g. for checklists, chores, etc. Compare with: https://play.google.com/store/apps/details?id=name.obrien.dave.lister&hl=en_GB.

This also makes the shopping_list.complete_all and shopping_list.uncomplete_all actions available to any to-do integration.

Service allows easy integration with UI and automations. Logically, if there's a service to bulk remove completed items, then there should be a service to bulk reset them to "not completed".

For example, you can have a list of daily chores as a todo list, then reset them all to needed at midnight via an automation. Much easier than making an "input boolean" for each one.

This is just the core PR. I'll do the docs and frontend when this has been reviewed.

Architecture discussion: home-assistant/architecture#1305

It's up to the individual integrations to determine how to implement the bulk updates,
since this needs to be done efficiently and in a way that best suits that integration.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes # NA
  • This PR is related to issue: NA
  • Link to documentation pull request: TODO
  • Link to developer documentation pull request: NA
  • Link to frontend pull request: TODO

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Nov 6, 2025

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (todo) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of todo can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign todo Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@emontnemery emontnemery mentioned this pull request Nov 6, 2025
21 tasks
Comment thread homeassistant/components/todo/__init__.py Outdated
@jamesmyatt jamesmyatt force-pushed the todo_reusable branch 3 times, most recently from 4ce0117 to 064de99 Compare November 10, 2025 09:59
@jamesmyatt jamesmyatt marked this pull request as ready for review November 10, 2025 18:14
@jamesmyatt jamesmyatt requested a review from a team as a code owner November 10, 2025 18:14
Copy link
Copy Markdown
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is changing our entity model. Before we can review this PR there needs to be approval in a discussion in our architecture repository.

https://github.com/home-assistant/architecture/discussions

https://developers.home-assistant.io/docs/core/entity#changing-the-entity-model

@home-assistant home-assistant Bot marked this pull request as draft November 11, 2025 14:03
@home-assistant
Copy link
Copy Markdown
Contributor

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@jamesmyatt
Copy link
Copy Markdown
Author

Thanks, @joostlek. I knew there was a discussion to be had, but it wasn't clear to me where to have it, since this is my first time. Here it is now: home-assistant/architecture#1305.

Comment thread homeassistant/components/todo/__init__.py Outdated
@github-actions
Copy link
Copy Markdown

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
If you are the author of this PR, please leave a comment if you want to keep it open. Also, please rebase your PR onto the latest dev branch to ensure that it's up to date with the latest changes.
Thank you for your contribution!

@jamesmyatt
Copy link
Copy Markdown
Author

jamesmyatt commented Jan 17, 2026

For me, this is still open. But I didn't really get useful feedback on the discussion: home-assistant/architecture#1305.

@github-actions github-actions Bot removed the stale label Jan 17, 2026
@github-actions
Copy link
Copy Markdown

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
If you are the author of this PR, please leave a comment if you want to keep it open. Also, please rebase your PR onto the latest dev branch to ensure that it's up to date with the latest changes.
Thank you for your contribution!

@github-actions github-actions Bot added the stale label Mar 18, 2026
@jamesmyatt
Copy link
Copy Markdown
Author

Architecture discussion has been approved: home-assistant/architecture#1305

@jamesmyatt jamesmyatt marked this pull request as ready for review March 19, 2026 20:14
Copilot AI review requested due to automatic review settings March 19, 2026 20:14
Copilot AI review requested due to automatic review settings June 1, 2026 17:16
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 8 comments.

Comment thread homeassistant/components/todo/services.yaml Outdated
Comment thread homeassistant/components/todo/__init__.py
Comment thread homeassistant/components/local_todo/todo.py
Comment thread homeassistant/components/shopping_list/todo.py
Comment thread tests/components/todo/test_init.py
Comment thread tests/components/todo/test_init.py Outdated
Comment thread tests/components/local_todo/test_todo.py
Comment thread homeassistant/components/todo/__init__.py
@jamesmyatt jamesmyatt requested a review from Copilot June 1, 2026 19:56
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 5 comments.

Comment thread homeassistant/components/shopping_list/todo.py
Comment thread homeassistant/components/local_todo/todo.py
Comment thread homeassistant/components/todo/__init__.py
Comment thread tests/components/todo/test_init.py Outdated
Comment thread homeassistant/components/local_todo/todo.py Outdated
Copilot AI review requested due to automatic review settings June 1, 2026 21:23
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 5 comments.

Comment thread homeassistant/components/todo/__init__.py
Comment thread homeassistant/components/local_todo/todo.py
Comment thread tests/components/todo/test_init.py
Comment thread homeassistant/components/todo/services.yaml
Comment thread homeassistant/components/local_todo/todo.py Outdated
@jamesmyatt jamesmyatt marked this pull request as ready for review June 1, 2026 21:45
Copilot AI review requested due to automatic review settings June 1, 2026 21:45
@home-assistant home-assistant Bot requested a review from allenporter June 1, 2026 21:46
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 6 comments.

Comment thread tests/components/todo/test_init.py
Comment thread homeassistant/components/local_todo/todo.py
Comment thread homeassistant/components/todo/__init__.py
Comment thread homeassistant/components/shopping_list/todo.py
Comment thread tests/components/todo/test_init.py
Comment thread homeassistant/components/local_todo/todo.py Outdated
Copilot AI review requested due to automatic review settings June 2, 2026 12:58
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 5 comments.

Comment thread homeassistant/components/shopping_list/todo.py
Comment thread homeassistant/components/local_todo/todo.py
Comment thread tests/components/todo/test_init.py
Comment thread tests/components/todo/test_init.py
Comment thread homeassistant/components/todo/__init__.py
Copilot AI review requested due to automatic review settings June 2, 2026 15:31
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 4 comments.

Comment thread homeassistant/components/todo/__init__.py
Comment thread homeassistant/components/todo/strings.json
Comment thread tests/components/todo/test_init.py
Comment thread tests/components/todo/test_init.py
(todo) Better strings for update_list
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants