Skip to content

fix(v6): raise HoleAuthenticationError for invalid password on HTTP 200 #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
qnorsten wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(v6): raise HoleAuthenticationError for invalid password on HTTP 200 #38

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions hole/v6.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,8 +115,11 @@ async def authenticate(self):
session_data = data.get("session", {})

if not session_data.get("valid"):
raise exceptions.HoleError(
"Authentication unsuccessful: Invalid session"
# Pi-hole v6 returns HTTP 200 with valid=false for wrong passwords
# rather than HTTP 401. Raise the same exception as the 401 path so
# callers can treat both cases uniformly.
raise exceptions.HoleAuthenticationError(
"Authentication failed: Invalid password", status=200
)

self._session_id = session_data.get("sid")
Expand Down