Support sample table data in DBML by hdnax · Pull Request #800 · holistics/dbml

hdnax · 2026-01-16T02:50:27Z

Summary

Add support for sample table data in DBML.

Doc: https://github.com/holistics/dbml/blob/78d79441758adc973376a18531b8d0b3807f9208/dbml-homepage/docs/docs.md
TDD: https://www.notion.so/holistics/TDD-80-Sample-Table-Data-2e6f89dc7e498073ac17c09a842aa64b

Support CommaExpressionNode in parser

Added CommaExpressionNode to AST for comma-separated value lists
Added lexer support for scientific notation (e.g., 1.23e5, -4.56e-3)

Support sample table data in DBML

Table Users {
  id string [pk]
  name string
  age int

  Records { // implicit columns
    "id1", "Alice", 18
    "id2", "Bob", 19
  }

  Records (id, name) { // explicit columns
    "id3", "Charlie"
  }
}

Records Users(id, name) { // always explicit
  "id4", "David"
}

Implicit/explicit column lists
Full type validation and constraint checking (PK, FK, unique, not null)
Support for strings, numbers, booleans, dates, enums, null, and SQL expressions
Validation warnings instead of errors for constraint violations

Handle INSERT statements in importers and exporters

Exporters: Convert Records to INSERT statements for all SQL dialects (MySQL, PostgreSQL, Oracle, MSSQL, Snowflake) with automatic FK constraint handling

Importers: Parse INSERT statements from SQL and convert to DBML Records, including Snowflake support

Add diagnostics provider for reusable logic related to errors and warnings

New DBMLDiagnosticsProvider class with provideDiagnostics(), provideErrors(), provideWarnings() methods

Others

Hardcode Report<T, E> to Report
- E is now always CompileError, also CompileWarning is supported
- Simplified API with getErrors() and getWarnings() methods
Expose reusable SQL type checking and value extraction functions
- Type checkers: isSqlNumericType(), isSqlStringType(), isSqlDateTimeType(), isSqlBooleanType()
- Value extractors: tryExtractBoolean(), tryExtractInteger(), tryExtractFloat(), tryExtractString(), tryExtractDate(), tryExtractDateTime(), tryExtractTime()
- Utilities: normalizeRecordValue(), addDoubleQuoteIfNeeded()

Issue

(issue link here)

…t checking

github-actions · 2026-02-06T08:01:03Z

Coverage Report

Commit: 8db33f4

📊 View detailed HTML coverage reports

Overall Coverage

Metric	Coverage
Lines	✅ 86.66% (8704/10044)
Statements	✅ 85.87% (9352/10891)
Functions	✅ 90.15% (2206/2447)
Branches	⚠️ 76.07% (4559/5993)

Package Coverage

Package	Lines	Statements	Functions	Branches
@dbml/dbml-cli	✅ 100.00%	✅ 100.00%	✅ 100.00%	✅ 100.00%
@dbml/dbml-connector	⚠️ 64.58%	⚠️ 64.29%	⚠️ 59.53%	⚠️ 59.13%
@dbml/dbml-core	✅ 90.80%	✅ 89.76%	✅ 91.04%	⚠️ 76.79%
@dbml/dbml-parse	✅ 87.71%	✅ 86.92%	✅ 93.68%	⚠️ 78.26%

⚠️ Coverage Warnings

The following packages have coverage below 80%:

@dbml/dbml-connector: 64.58% line coverage

Files with Coverage Below 80%

@dbml/dbml-connector

9 file(s) below 80% coverage

File	Lines	Statements	Functions	Branches
`src/connectors/bigquery/index.ts`	0.00%	0.00%	0.00%	0.00%
`src/utils/credential-loader.ts`	0.00%	0.00%	0.00%	0.00%
`src/utils/helpers.ts`	0.00%	0.00%	0.00%	0.00%
`src/connectors/snowflake/index.ts`	10.56%	10.31%	0.00%	0.00%
`src/utils/parseSchema.ts`	46.15%	42.85%	28.57%	27.27%
`src/connectors/connector.ts`	66.66%	66.66%	100.00%	57.14%
`src/connectors/oracle/tables.ts`	71.25%	66.30%	100.00%	56.96%
`src/connectors/oracle/index.ts`	80.00%	80.76%	100.00%	25.00%
`src/connectors/oracle/utils.ts`	85.71%	85.71%	100.00%	71.42%

@dbml/dbml-core

30 file(s) below 80% coverage

File	Lines	Statements	Functions	Branches
`src/parse/error.js`	0.00%	0.00%	0.00%	0.00%
`src/parse/ANTLR/ASTGeneration/SyntaxError.js`	0.00%	0.00%	0.00%	0.00%
`src/transform/index.js`	0.00%	0.00%	0.00%	100.00%
`src/utils/version.js`	0.00%	0.00%	100.00%	100.00%
`src/model_structure/element.js`	16.66%	16.66%	25.00%	0.00%
`src/parse/databaseGenerator.js`	18.42%	17.94%	0.00%	0.00%
`src/import/index.js`	50.00%	50.00%	50.00%	100.00%
`src/model_structure/utils.js`	50.00%	50.00%	50.00%	0.00%
`src/export/JsonExporter.js`	66.66%	66.66%	100.00%	33.33%
`src/parse/ANTLR/ASTGeneration/ParserErrorListener.js`	66.66%	66.66%	50.00%	100.00%
`src/parse/Parser.js`	67.30%	64.81%	62.50%	61.90%
`src/export/utils.js`	73.17%	73.80%	90.00%	54.54%
`src/model_structure/schema.js`	76.11%	78.94%	86.04%	32.35%
`src/model_structure/tableGroup.js`	80.64%	81.25%	80.00%	38.09%
`src/export/ModelExporter.js`	82.35%	82.35%	100.00%	58.33%
`src/parse/ANTLR/ASTGeneration/mssql/MssqlASTGen.js`	85.75%	83.86%	89.10%	67.31%
`src/parse/ANTLR/ASTGeneration/oraclesql/OracleSQLASTGen.js`	85.88%	83.97%	91.86%	70.23%
`src/parse/ANTLR/ASTGeneration/snowflake/SnowflakeASTGen.js`	89.34%	89.95%	92.42%	78.10%
`src/model_structure/enum.js`	90.90%	91.66%	100.00%	33.33%
`src/parse/ANTLR/ASTGeneration/AST.js`	91.11%	91.11%	76.47%	77.77%
`src/model_structure/check.js`	92.30%	92.30%	83.33%	66.66%
`src/model_structure/endpoint.js`	92.85%	94.00%	100.00%	65.38%
`src/model_structure/enumValue.js`	92.85%	92.85%	100.00%	75.00%
`src/model_structure/tablePartial.js`	92.85%	92.85%	80.00%	77.77%
`src/model_structure/ref.js`	93.33%	93.54%	100.00%	69.23%
`src/model_structure/table.js`	94.25%	91.91%	97.67%	61.01%
`src/model_structure/indexes.js`	96.55%	96.77%	100.00%	72.72%
`src/parse/ANTLR/ASTGeneration/index.js`	98.21%	90.16%	100.00%	62.50%
`src/model_structure/stickyNote.js`	100.00%	100.00%	100.00%	0.00%
`src/parse/ANTLR/ASTGeneration/helpers.js`	100.00%	83.33%	100.00%	75.00%

@dbml/dbml-parse

38 file(s) below 80% coverage

File	Lines	Statements	Functions	Branches
`src/compiler/queries/container/scope.ts`	0.00%	0.00%	0.00%	100.00%
`src/services/diagnostics/provider.ts`	0.00%	0.00%	0.00%	0.00%
`src/compiler/queries/parse.ts`	50.00%	50.00%	50.00%	100.00%
`src/core/interpreter/elementInterpreter/project.ts`	51.42%	51.42%	100.00%	36.36%
`src/core/interpreter/records/utils/data/sqlTypes.ts`	56.25%	58.82%	75.00%	46.55%
`src/core/analyzer/symbol/utils.ts`	56.52%	56.52%	100.00%	50.00%
`src/core/analyzer/binder/elementBinder/note.ts`	62.50%	64.70%	83.33%	50.00%
`src/compiler/queries/utils.ts`	64.83%	65.95%	88.88%	52.11%
`src/core/interpreter/records/utils/data/values.ts`	65.13%	57.14%	72.72%	50.37%
`src/compiler/queries/token.ts`	66.66%	66.66%	66.66%	100.00%
`src/core/analyzer/validator/elementValidators/indexes.ts`	72.00%	72.83%	90.90%	57.69%
`src/core/analyzer/binder/elementBinder/enum.ts`	72.22%	73.68%	100.00%	62.50%
`src/core/analyzer/validator/elementValidators/note.ts`	72.54%	70.90%	76.92%	68.75%
`src/core/analyzer/analyzer.ts`	75.00%	66.66%	60.00%	100.00%
`src/core/analyzer/symbol/symbolIndex.ts`	76.92%	77.50%	92.85%	50.00%
`src/core/analyzer/utils.ts`	77.77%	76.36%	88.88%	75.00%
`src/core/analyzer/binder/elementBinder/project.ts`	77.77%	78.94%	100.00%	50.00%
`src/core/analyzer/validator/elementValidators/checks.ts`	77.77%	79.31%	93.75%	71.87%
`src/core/analyzer/validator/elementValidators/records.ts`	78.08%	78.66%	93.75%	74.19%
`src/core/analyzer/validator/elementValidators/project.ts`	78.12%	78.78%	100.00%	56.25%
`src/core/utils.ts`	78.57%	77.41%	80.00%	60.71%
`src/core/analyzer/binder/elementBinder/ref.ts`	78.78%	80.00%	90.90%	75.00%
`src/core/analyzer/binder/elementBinder/indexes.ts`	79.06%	77.77%	90.90%	68.18%
`src/core/analyzer/binder/elementBinder/tableGroup.ts`	80.00%	80.64%	100.00%	50.00%
`src/services/suggestions/utils.ts`	80.39%	75.00%	92.85%	68.51%
`src/core/interpreter/records/utils/constraints/pk.ts`	82.00%	80.00%	92.30%	54.54%
`src/core/analyzer/binder/elementBinder/records.ts`	82.79%	83.33%	93.75%	71.42%
`src/compiler/queries/container/token.ts`	83.33%	85.71%	100.00%	75.00%
`src/core/analyzer/validator/elementValidators/tablePartial.ts`	83.43%	80.72%	87.23%	64.28%
`src/core/analyzer/binder/elementBinder/tablePartial.ts`	86.00%	86.53%	100.00%	69.23%
`src/core/parser/parser.ts`	86.65%	86.81%	100.00%	78.57%
`src/services/suggestions/recordRowSnippet.ts`	88.67%	84.61%	100.00%	78.00%
`src/compiler/queries/symbol.ts`	91.30%	92.00%	100.00%	78.57%
`__tests__/utils/compiler.ts`	92.92%	92.75%	100.00%	69.23%
`src/core/interpreter/elementInterpreter/sticky_note.ts`	95.00%	95.23%	100.00%	66.66%
`src/core/interpreter/records/utils/constraints/unique.ts`	96.15%	93.93%	100.00%	66.66%
`src/core/analyzer/symbol/symbolTable.ts`	100.00%	100.00%	100.00%	75.00%
`src/services/definition/provider.ts`	100.00%	100.00%	100.00%	75.00%

hdnax force-pushed the feat/sample-table-data branch 6 times, most recently from e75ad9b to 7a79669 Compare January 16, 2026 07:52

hdnax force-pushed the parser/refactor-binder branch from 447eb87 to 509240a Compare January 16, 2026 09:03

hdnax force-pushed the feat/sample-table-data branch 7 times, most recently from 4fb94da to 20f2cb1 Compare January 19, 2026 03:07

hdnax requested a review from xuantho573 January 19, 2026 06:26

hdnax force-pushed the feat/sample-table-data branch 7 times, most recently from b245e94 to 9fa707d Compare January 22, 2026 13:12

Base automatically changed from parser/refactor-binder to master January 25, 2026 07:56

hdnax force-pushed the feat/sample-table-data branch 7 times, most recently from 6b9699e to 9aa84ab Compare January 26, 2026 04:30

hdnax added 28 commits February 6, 2026 14:44

refactor: simply fk constraint checker

5bb8020

test: update tests

e299c35

refactor: simplify constraint checker

793d998

test: remove duplicate validator tests

ec63cbf

test: remove duplicate binder tests

9996c9b

test: update tests

c224f97

test: remove duplicate interpreter tests

fe8b98d

test: update tests

14cc126

test: fix unclosed open handles

ad39418

doc: fix typo

2193fb4

fix: bug in mssql exporter causing false to be exported as 1

b75d7b8

test: remove unnecessary tests

c6ce478

fix: oracle and postgres exporter to properly defer/disable constrain…

1a78346

…t checking

test: update tests

78c76c9

test: update tests

fb1ba68

test: update tests

8ffbbfe

chore: use setMode instead of the deprecated mode

7e1b981

doc: improve the content of Data Sample section

e74fe37

test: update tests

74ea811

doc: remove dead links

b052429

doc: remove unnecessary test

f306148

test: update tests

3c1dbf6

test: remove unnecessary snapshots

866ff8d

test: remove unnecessary tests

3a39295

fix: disallow any identifiers other than null, true, false

1fafee9

refactor: make pk validator more readable

adbfb0a

refactor: unique validator

905bea1

fix: move source to ast & no longer expose serialize

a2dacd8

hdnax force-pushed the feat/sample-table-data branch from 11a5294 to a2dacd8 Compare February 6, 2026 07:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support sample table data in DBML#800

Support sample table data in DBML#800
hdnax wants to merge 201 commits intomasterfrom
feat/sample-table-data

hdnax commented Jan 16, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Feb 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

hdnax commented Jan 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Support CommaExpressionNode in parser

Support sample table data in DBML

Handle INSERT statements in importers and exporters

Add diagnostics provider for reusable logic related to errors and warnings

Others

Issue

Uh oh!

github-actions bot commented Feb 6, 2026

Coverage Report

Overall Coverage

Package Coverage

⚠️ Coverage Warnings

Files with Coverage Below 80%

@dbml/dbml-connector

@dbml/dbml-core

@dbml/dbml-parse

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

hdnax commented Jan 16, 2026 •

edited

Loading