Repository navigation
Rejects batches instead of hanging when open fails - #128
Merged
kasperisager merged 4 commits intoNov 13, 2026
Merged
Conversation
tur-nr
marked this pull request as draft
November 3, 2026 04:04
[Medium impact] The PR appears safe to merge; no actionable new issues were found. SummaryBatches now reject when opening the database fails, rather than leaving callers waiting.
|
tur-nr
force-pushed
the
fix/batch-flush-open-error
branch
from
November 3, 2026 10:11
483d2ac to
778bc4e
Compare
tur-nr
marked this pull request as ready for review
November 4, 2026 03:54
Contributor
|
@tur-nr Are you looking into the leak that trips up the tests? |
Contributor
Author
|
@kasperisager see holepunchto/librocksdb#45 I guess my test was forcing a db failure which exposed an underlaying leak in the lib. |
Contributor
|
Great catch! |
kasperisager
approved these changes
Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
When the db fails to open, for example on a locked directory, batches never settle.
flush(), the operations queued on it anddb.get()hang, and the open error only shows up as an unhandled rejection.Proposal
A failed flush rejects with its error, along with everything queued on the batch.
Testing
Reads on a db whose open failed reject instead of hanging, through both a batch flush and
db.get().Notes
Bumps
librocksdbto pick up holepunchto/librocksdb#45. A failed open leaked the env, which the new test's locked open surfaced under ASan.