Skip to content

Fixes read-only WAL filter test on re-runs - #41

Merged
kasperisager merged 1 commit into
holepunchto:mainfrom
tur-nr:fix/read-only-wal-filter-idempotent
Sep 23, 2026
Merged

kasperisager merged 1 commit into
holepunchto:mainfrom
tur-nr:fix/read-only-wal-filter-idempotent

Conversation

@tur-nr

@tur-nr tur-nr commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

Problem

read-only-wal-filter passes once and fails on every subsequent local run. On the second open RocksDB recovers the surviving WAL and flushes it to an L0 table, so b:1 is already in an SST before the read-only open and the filter never gets the chance to drop it. CI checks out fresh every run, so it has never shown up there.

Proposal

  • Remove the fixture database at the start of the test
  • Keeps the persistent test/fixtures/<name>.db convention the rest of the suite uses

Tests

The assertions are unchanged: both keys still go into a live WAL, the reopen is still read-only with the a: prefix filter, and a:1 surviving while b:1 does not is still what is being proved. Verified by running the binary five times against an already-dirty fixture, once with the fixture removed entirely, and the full suite three times with no cleaning in between.

@tur-nr
tur-nr requested a review from a team September 23, 2026 06:11
@kasperisager
kasperisager merged commit 9e01fa6 into holepunchto:main Sep 23, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants