Repository navigation
Fixes read-only WAL filter test on re-runs - #41
Merged
kasperisager merged 1 commit intoSep 23, 2026
Merged
Conversation
kasperisager
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
read-only-wal-filterpasses once and fails on every subsequent local run. On the second open RocksDB recovers the surviving WAL and flushes it to an L0 table, sob:1is already in an SST before the read-only open and the filter never gets the chance to drop it. CI checks out fresh every run, so it has never shown up there.Proposal
test/fixtures/<name>.dbconvention the rest of the suite usesTests
The assertions are unchanged: both keys still go into a live WAL, the reopen is still read-only with the
a:prefix filter, anda:1surviving whileb:1does not is still what is being proved. Verified by running the binary five times against an already-dirty fixture, once with the fixture removed entirely, and the full suite three times with no cleaning in between.